[postgis-devel] fix for memory leaks in shp2pgsql.c

Paul Ramsey pramsey at cleverelephant.ca
Tue Oct 13 16:24:56 PDT 2009


Maybe I just dreamed about fixing it. Or maybe I fixed something
egregious and left behind something less noticeable in my use case.

On Tue, Oct 13, 2009 at 4:11 PM, Dave Fuhry <dfuhry at gmail.com> wrote:
> Paul,
>
>   1.4.0.
>
>   I originally hit the problem on 1.3.x, then patched 1.4.0, which
> I'm /pretty/ sure was exhibiting the problem.
>
>   It was easy to see in `top` that shp2pgsql was gorging on memory as
> execution continued, and the leak locations were revealed fairly
> clearly in `valgrind --leak-check=full`.  This work is all against
> polygons; my impression is that loading of points or linestrings is
> unaffected.
>
> -Dave
>
>
> On Tue, Oct 13, 2009 at 5:32 PM, Paul Ramsey <pramsey at cleverelephant.ca> wrote:
>> Huh, what version is this against? I thought I had cleaned those out.
>>
>> P.
>>
>> On Tue, Oct 13, 2009 at 2:21 PM, Dave Fuhry <dfuhry at gmail.com> wrote:
>>> This patch fixes memory leaks in shp2pgsql.c.
>>>
>>> Previously, loading a 1.5GB shapefile was running a 4GB machine out of memory.
>>>
>>> -Dave
>>>
>>> _______________________________________________
>>> postgis-devel mailing list
>>> postgis-devel at postgis.refractions.net
>>> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>>>
>>>
>> _______________________________________________
>> postgis-devel mailing list
>> postgis-devel at postgis.refractions.net
>> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>>
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>



More information about the postgis-devel mailing list