[postgis-devel] Parser/Emitter Changeover
Paul Ramsey
pramsey at cleverelephant.ca
Sat Dec 4 00:15:40 PST 2010
Today I started changing over the WKB/WKT parser and emitters to the
new code. It has been, as you can imagine, fraught. I still have 10
failing tests in the regression suite, though all the cunit stuff now
passes. In working through the SQL regressions, there are a few things
I have been changing in the regression tests themselves, rather than
forcing the new code to ape the old. Here's the things I have changed
so far:
- In EWKT, collections of M-dimensioned objects have the M flag on all
subcomponents as well as parent components.
eg: CURVEPOLYGONM(CIRCULARSTRINGM(..))
- The maximum SRID value is now enforced at 999999, so the value embedded
in two tests was reduced to less that that.
- Some of the position numbers and error hints have been slightly
altered as the parser picks up errors sometimes 1 or 2 columns
farther to the right or left.
- Set the number of patches in a POLYHEDRALSURFACE EMPTY to '0'
instead of NULL
Hopefully that will be all that changes. There might be a few others
where the reason for invalidity in a piece of WKT switches from
"unclosed ring" to "not enough points" and stuff like that. Let me
know if you have any concerns. I hope to have this stuff committed
early next week, if not sooner.
Paul
More information about the postgis-devel
mailing list