[postgis-devel] Another Styling Possibility?

[Kevin Neufeld]

Yeah, I could set this up on Hudson if that's what folks want.  The current version of astyle is 1.23 on the build box.

It'll make things difficult to determine who broke the build, though.
Consider:
   - person A commits to source with breaking code.
   - svn hook triggers a hudson build with person A as last committing author
   - hudson styles the code, detects changes, commits and exits
   - svn hook triggers another build with hudson as last committing author
   - hudson styles the code, no change
   - hudson continues to build the source, encounters a build problem
   - hudson emails/spams the last person (itself), notifying them of the broken build.

Other ideas?
-- Kevin

On 2/22/2010 6:24 AM, Paul Ramsey wrote:
> Not only to run make astyle, but to do so using the "blessed" version,
> since we have now discovered that all versions produce slightly
> different output. Could be beyond annoying.
>
> P
>
> On Mon, Feb 22, 2010 at 6:05 AM, Maxime van Noppen<maxime at altribe.org>  wrote:
>> On 02/22/2010 03:01 PM, Paul Ramsey wrote:
>>> I just read up on svn hooks, and it doesn't support hooks that alter
>>> the input, only ones that accept/reject the commit and have
>>> side-effects (like posting to a mail list or irc or whatever).
>>>
>>> Jeff had a suggestion, which was to use a hudson process that, on each
>>> commit, runs astyle and commits any format changes. This would neatly
>>> separate code changes from format changes in the commits, which would
>>> be nice.
>>
>> What about having a hook that rejects the commit if it is not correctly
>> formatted ? This would "force" the developers to remember to run 'make
>> astyle' before committing though it might be annoying.
>>
>> --
>> Maxime
>> _______________________________________________
>> postgis-devel mailing list
>> postgis-devel at postgis.refractions.net
>> http://postgis.refractions.net/mailman/listinfo/postgis-devel
>>
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at postgis.refractions.net
> http://postgis.refractions.net/mailman/listinfo/postgis-devel