[postgis-devel] [PostGIS] #343: History Table Enhancements

[PostGIS]

#343: History Table Enhancements
----------------------------+-----------------------------------------------
 Reporter:  pimpaa          |       Owner:  pimpaa       
     Type:  defect          |      Status:  new          
 Priority:  medium          |   Milestone:  PostGIS 2.0.0
Component:  postgis         |     Version:  trunk        
 Keywords:  History Tables  |  
----------------------------+-----------------------------------------------

Comment(by robe):

 George,

 Sorry for delay on this.  I took another look and it still needs work:

 1)On your line 61 -- "THE HISTORIC INFORMATION TABLE WAS DROPPED.
 FUNCTIONS MARKED FOR DELETION.".  Needs to be single quoted instead of
 double-quoted.  didn't install without changing to '.

 2) Your postgis_enable_history assumes that historic_information etc. will
 be installed in public.  I dont' think we should make this assumption.  I
 would just get rid of the public or if you want this to be always
 installed in a specific schema, then create one and use that instead of
 public (similar to wha tis done with topology).

 3) Most importantly, this code does not work with PostGIS 2.0 because it
 tries to write to geometry_columns which is now a view.  Best thing to do
 is change that logic to use

 populate_geometry_columns(..)

 http://www.postgis.org/documentation/manual-
 svn/Populate_Geometry_Columns.html

 This will do the right thing for both PostGIS 1.4-1.5 and PostGIS 2.0

 I see some other issues such as missing use of quote_ident, quote_literal
 etc. but wasn't able to test those issues because of the aforementioned.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/343#comment:14>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.