[postgis-devel] [PostGIS] #1158: Can't compile under Windows mingw

[PostGIS]

#1158: Can't compile under Windows mingw
---------------------+------------------------------------------------------
 Reporter:  robe     |       Owner:  strk         
     Type:  defect   |      Status:  new          
 Priority:  blocker  |   Milestone:  PostGIS 2.0.0
Component:  postgis  |     Version:  trunk        
 Keywords:           |  
---------------------+------------------------------------------------------

Comment(by bnordgren):

 Replying to [comment:25 strk]:
 > PG_MODULE_MAGIC macro is in libpgcommon/lwgeom_pg.c, wrapped in an
 ifdef.
 > Could you try commenting out the #ifdef/#endif parts maybe ? Or could
 again be an ordering problem.

 This is the same code as it existed pre-move
 (source:/trunk/postgis/lwgeom_pg.c at 7733). Prior to the formation of
 libpgcommon, both postgis and raster included this code separately. After
 making libpgcommon, I was having problems with raster-2.0.so due to a
 duplicate symbol definition (once in libpgcommon and once in raster.) I
 elected to remove the definition from rt_pg.c in favor of the common
 location. `postgis-2.0.so` was fine because it included the symbol only
 once. And all rejoiced, having passed the regression tests.

 If I understand the problem correctly, linux copies this symbol when
 linking from `postgis-2.0.so` to `libpgcommon.a`, but Windows dllwrap
 filters it out (perhaps because it is never referenced). If we cannot find
 a way to please all linkers, I would suggest moving this code snippet back
 into `rt_pg.c` and one `*.c` file of your choice in the postgis directory.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/1158#comment:26>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.