[postgis-devel] [PostGIS] #1746: Upgrade scripts are not installing all functions (was: Moving postgis extension to another schema leaves things behind)

[PostGIS]

#1746: Upgrade scripts are not installing all functions
-----------------------------------+----------------------------------------
 Reporter:  robe                   |       Owner:  strk         
     Type:  defect                 |      Status:  new          
 Priority:  high                   |   Milestone:  PostGIS 2.0.0
Component:  build/upgrade/install  |     Version:  trunk        
 Keywords:                         |  
-----------------------------------+----------------------------------------
Changes (by robe):

  * owner:  pramsey => strk
  * priority:  medium => high
  * component:  postgis => build/upgrade/install
  * milestone:  PostGIS 2.0.1 => PostGIS 2.0.0


Comment:

 I have determined this not to be a flaw in the extensions machinery but a
 flaw in our upgrade scripts that not only affects extensions but all our
 upgrade scripts.  The issue is our script that generates the upgrade
 scripts is missing installing functions.  It seems it misses functions if
 they start with a function already present with similar arguments.

 For example

 {{{
 st_dump -- doesn't get installed presumably because our upgrade confuses
 it with st_dumppoints
 st_isvaliddetail -- another -- looks very similar to st_isvaliddetail that
 takes two args

 st_intersection raster is another - this one however may be permutations
 of st_intersection that we aren't dropping.  I'll have to investigate that
 closer
 }}}


 This is just something that happens to be much easier to detect with
 extensions because extensions allow you to move all objects packaged in an
 extension to another schema with a 1 line command.  What happens how the
 extension upgrade script is catching this is

 1) As part of upgrade, I drop all functions from the extensions with the
 assumption that our upgrade scripts will reinstall all functions except
 possibly aggregates.

 2) It doesn't apparently so the functions it doesn't install are still
 installed but are no longer part of the postgis extension.

 It's not super super critical because I it will only affect people
 upgrading from very very early on in the cycle before we introduced these
 and will get fixed as soon as we fix this.

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/1746#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.