[postgis-devel] Building on FreeBSD

[Greg Troxel]

Robert Kruus <rob.kruus at gmail.com> writes:

> The fix in ticket http://trac.osgeo.org/postgis/ticket/2620 breaks
> compiling on my FreeBSD box (for 2.1 obviously and most likely from there
> forward).
>
> Probably want to add another || in there:
>
> #if defined(__FreeBSD__) || defined(__FreeBSD_kernel__) ||
> defined(__OpenBSD__)
>
> Also see
>
> https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192840#c30

I am having trouble following this.    It seems suboptimal to be
checking for a define that asserts a kernel implementation.   Does
kFreeBSD install header files in /usr/include/sys that match the kernel
interfaces?  Why isn't there instead a feature test from kernel headers,
rather than a specific name?

It seems particularly dodgy to define LINUX on systems that aren't
linux, or for things to be ifdef'd on LINUX, rather than aiming for
POSIX.  But I have no historical context for this entire situation, so I
could well be missing something.
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 180 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20140822/cb98fd10/attachment.sig>