[postgis-devel] Rename a variable named errmsg in long_xact.c

[Sandro Santilli]

On Mon, May 04, 2015 at 12:44:46PM +1000, Haribabu Kommi wrote:
> Hi,
> 
> In the improvement of better logging purpose in our forked PostgreSQL
> source code,
> we changed the existing elog macros to use the new error reporting
> functionality macros without need of changing the existing modules
> source code that are using the elog macro.
> 
> In this development we find a problem in compiling PostGIS source code
> with our forked PostgreSQL source code because of a variable named as
> errmsg in long_xact.c
> 
> Here I attached a patch to change the variable name from errmsg to
> err_msg. As this change is required in this file if we are going to
> use the new error reporting functionality.
> 
> Please let me know if it not the right approach to solve the problem.

I see no problem with changing a variable name, but... are you saying
that PostgreSQL headers themselves are exposing a global "errmsg"
variable ? Or is your code doing that ?

--strk;

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html