[postgis-devel] 2.2.0 passes regression tests on NetBSD 6 i386, perl path issue

[Sandro Santilli]

On Fri, Oct 09, 2015 at 03:44:11PM -0400, Greg Troxel wrote:
> 
> I updated the pkgsrc package from 2.1.7 to 2.2.0 and it passes
> regression tests (pgsql 9.3.9, geos 3.5.0, proj 4.9.2).
> 
> Should I be foisting this on the pkgsrc-using world, or waiting until
> 2.2.1?  It doesn't feel urgent if that's coming within weeks.
> 
> One of the things I notice in packaging is changes in the set of
> installed files.   That's not a bug of course, but a chance to see if
> the changes are entirely intended.
> 
> Extracts from a diff -u, with all the noise removed:
> 
>   +include/liblwgeom_topo.h
>   +lib/postgresql/postgis_topology-2.2.so
> 
>   -share/postgresql/contrib/postgis-2.1/topology.sql
>   -share/postgresql/contrib/postgis-2.1/topology_upgrade_21_minor.sql
>   -share/postgresql/contrib/postgis-2.1/uninstall_sfcgal.sql
>   -share/postgresql/contrib/postgis-2.1/uninstall_topology.sql
> 
>   +share/postgresql/contrib/postgis_topology-2.2/topology.sql
>   +share/postgresql/contrib/postgis_topology-2.2/topology_upgrade.sql
>   +share/postgresql/contrib/postgis_topology-2.2/uninstall_topology.sql
> 
> So there's a new header, and a new library - looks intended.
> 
> topology stuff in contrib is in a new subdir, compard to before, but the
> comments file didn't move down.  That looks not clearly intended.

No, it isn't intended. Could you please file a ticket ?
It'll need to be taken care of both in 2.2 branch and trunk.

> if they could be different.  I vote for not using the pgxs perl path at
> all, either by using @PERL@ instead of $(PERL) in makefiles, or my
> uniformly including pgxs first and then setting variables.

> --- extensions/postgis/Makefile.in.orig	2014-06-27 07:35:32.000000000 +0000
[...]
> --- extensions/postgis_topology/Makefile.in.orig	2014-06-27 07:35:32.000000000 +0000

I see PERL is defined and used _before_ PGXS is included in both
the files you send a patch for. Does it mean Makefiles includes
are processed before the rules ?

--strk;

  ()   Free GIS & Flash consultant/developer
  /\   http://strk.keybit.net/services.html