[postgis-devel] 2.4.0beta1 build error against PostgreSQL 10 beta 4

[Regina Obe]

I finally got around to retesting the tar ball I packaged against a compiled PostgreSQL 10 beta4.

Loading SFCGAL into 'postgis_reg'
PostgreSQL 10beta4 on x86_64-w64-mingw32, compiled by gcc.exe (x86_64-win32-seh-rev1, Built by MinGW-W64 project) 4.8.3, 64-bit
  Postgis 2.4.0beta1 - r15614 - 2017-09-05 18:01:21
  scripts 2.4.0beta1 r15614
  GEOS: 3.7.0dev-CAPI-1.11.0 8fe2ce6
  PROJ: Rel. 4.9.1, 04 March 2015
  SFCGAL: 1.3.0

It worked fine for me -- can you confirm you were testing with this tar ball and not something else.
http://download.osgeo.org/postgis/source/postgis-2.4.0beta1.tar.gz


If you were compiling against PostGIS 2.3, those errors you have below are expected since 2.3 hasn't been fixed to work with 10.

P.S I was mistaken about  gserialized_gist.c  that does exist in the postgis/liblpgcommon folder

As Vicky noted putting a float.h would fix the FLT_MAX issue -- would go at top of liblpgcommon/gserialzed_gist.h header



-----Original Message-----
From: postgis-devel [mailto:postgis-devel-bounces at lists.osgeo.org] On Behalf Of Devrim Gündüz
Sent: Sunday, September 03, 2017 6:00 PM
To: postgis-devel <postgis-devel at lists.osgeo.org>
Subject: [postgis-devel] 2.4.0beta1 build error against PostgreSQL 10 beta 4


Hi,

I'm getting this build error while building PostGIS 2.4.0beta1 against PostgreSQL 10beta4, on Fedora 26:

=================================================================================
In file included from gserialized_gist.c:17:0:
../postgis_config.h:150:31: error: invalid suffix "PostgreSQL" on integer constant  #define POSTGIS_PGSQL_VERSION 10PostgreSQL 10beta4
                               ^
lwgeom_pg.h:142:5: note: in expansion of macro 'POSTGIS_PGSQL_VERSION'
 #if POSTGIS_PGSQL_VERSION >= 85
     ^~~~~~~~~~~~~~~~~~~~~
../postgis_config.h:150:44: error: missing binary operator before token "10beta4"
 #define POSTGIS_PGSQL_VERSION 10PostgreSQL 10beta4
                                            ^
lwgeom_pg.h:142:5: note: in expansion of macro 'POSTGIS_PGSQL_VERSION'
 #if POSTGIS_PGSQL_VERSION >= 85
     ^~~~~~~~~~~~~~~~~~~~~
In file included from gserialized_gist.c:23:0:
gserialized_gist.c: In function 'gidx_from_gbox_p':
gserialized_gist.c:98:25: error: 'FLT_MAX' undeclared (first use in this function); did you mean 'AF_MAX'?
     GIDX_SET_MIN(a,2,-1*FLT_MAX);
                         ^
gserialized_gist.h:84:75: note: in definition of macro 'GIDX_SET_MIN'
 #define GIDX_SET_MIN(gidx, dimension, value) ((gidx)->c[2*(dimension)] = (value))
                                                                           ^~~~~
gserialized_gist.c:98:25: note: each undeclared identifier is reported only once for each function it appears in
     GIDX_SET_MIN(a,2,-1*FLT_MAX);
                         ^
gserialized_gist.h:84:75: note: in definition of macro 'GIDX_SET_MIN'
 #define GIDX_SET_MIN(gidx, dimension, value) ((gidx)->c[2*(dimension)] = (value))
                                                                           ^~~~~
gserialized_gist.c: In function 'gserialized_datum_get_gidx_p':
gserialized_gist.c:277:27: error: 'FLT_MAX' undeclared (first use in this function); did you mean 'AF_MAX'?
    GIDX_SET_MIN(gidx,2,-1*FLT_MAX);
                           ^
gserialized_gist.h:84:75: note: in definition of macro 'GIDX_SET_MIN'
 #define GIDX_SET_MIN(gidx, dimension, value) ((gidx)->c[2*(dimension)] = (value))
                                                                           ^~~~~ =================================================================================

Regards,
--
Devrim G nd z
EnterpriseDB: https://www.enterprisedb.com PostgreSQL Danismani/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR