[postgis-devel] [MOTION] remove generated parser files from repo

[Paul Ramsey]

There are also generated protobuf files.
I'm -0 on the motion. We have checked in those files because different
generator versions produce different output. Having them checked in
provides a certain stability and predictability. Maybe that's an opinion
from an earlier age when those tools changed more frequently, but checking
in the parsers and lexers has been a common feature of most projects I've
seen. Well, of PgSQL.
P.


On Tue, Sep 26, 2017 at 1:24 AM, Sandro Santilli <strk at kbt.io> wrote:

> I don't think non-source files should be under revision control
> so this motion is to drop the following files from repo:
>
>         liblwgeom/lwin_wkt_lex.c
>         liblwgeom/lwin_wkt_parse.c
>         liblwgeom/lwin_wkt_parse.h
>
> This is what happens currently if you run `make maintainer-clean`
>
> The Makefiles are already rebuilding those files when needed
> (missing or newer source).
>
> Note that Debbie, which automatically produces release tarballs,
> was found to regenerate those files anyway (probably due to
> modification timestamp of source files being newer than the one
> of generated files) so the final release get different files
> from those present in the repository anyway.
>
> Here's my +1 to the motion for removing those files.
>
> --strk;
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/postgis-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20170926/4b04b39e/attachment.html>