[postgis-devel] Code formatting digging in

[Paul Ramsey]

Isn't he removing spaces in both?
It looks like he doesn't like my old quirk of padding the conditional
bits. In fairness, it seems to be a minority position in the C
formatting community.
Shall we do another 12 rounds on auto-formatters?
P

On Thu, Feb 22, 2018 at 8:29 AM, Sandro Santilli <strk at kbt.io> wrote:
> Hi Darafei,
>
> On Thu, Feb 22, 2018 at 07:52:47AM +0000, Darafei wrote:
>> New Revision: 16409
>>
>> Modified:
>>    trunk/liblwgeom/lwgeom_geos_clean.c
>> Log:
>> Format lwgeom_geos_clean.c before digging in
>>
>> References #2508
>
> [...]
>
>> -     switch ( GEOSGeomTypeId(g_in) )
>> +     switch (GEOSGeomTypeId(g_in))
>
> Here you add spaces
>
>> -                     if ( ret ) return ret;
>> +                     if (ret) return ret;
>
> Here you remove spaces
>
> What's the rationale for this style change ?
>
> I think we should try not to change style unless we have
> a way to enforce a specific style always, and this is so
> far only done by the settings in .editorconfig.yml, which
> do not address spacing in conditions and switches...
>
> --strk;
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/postgis-devel