[postgis-devel] Code formatting digging in

[Paul Ramsey]

It doesn't seem to be installed by default by pgsql 'make install', so
it's not necessarily an easy tool to find. If we're bundling something
ourselves, there's no particular benefit to using pgindent over any
other formatter.

P

On Thu, Feb 22, 2018 at 10:48 AM, Tomas Vondra
<tomas.vondra at 2ndquadrant.com> wrote:
>
>
> On 02/22/2018 07:39 PM, Paul Ramsey wrote:
>> On Thu, Feb 22, 2018 at 10:36 AM, Sandro Santilli <strk at kbt.io> wrote:
>>> On Thu, Feb 22, 2018 at 07:05:14PM +0100, Sandro Santilli wrote:
>>>
>>>> QGIS (to look at close neighbours) used to ship their own version
>>>> of astyle to deal with it. Recently they introduced again ability
>>>> to use the system astyle, do we want to try that again ?
>>>> https://github.com/qgis/qgis/commit/c48e0069aee5360f71d3128a1f3c14775b7fb491
>>>>
>>>> QGIS now requires astyle 3.0+
>>>
>>> Just to give more info: the version of astyle that QGIS ships
>>> is 3.1, they just embed the full source code in qgis codebase.
>>>
>>> It only takes 664K:
>>>
>>>   664K    external/astyle/
>>>
>>> That'd be ~1% of the current PostGIS source code.
>>> I would not be against doing the same.
>>
>> Sold. I'm in.
>>
>
> Wouldn't it be more natural to adopt pgindent, considering it's what
> PostgreSQL uses?
>
> regards
>
> --
> Tomas Vondra                  http://www.2ndQuadrant.com
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services