[postgis-devel] Code formatting digging in

[Sandro Santilli]

On Fri, Feb 23, 2018 at 02:51:39PM +0100, Tomas Vondra wrote:
> On 02/23/2018 12:21 PM, Sandro Santilli wrote:

> > I'm sold, did I hear you volunteering to send a PR for integration
> > of that package in PostGIS ? Or I'll get to that eventually.
> 
> I can do that, yes. I suggest we do that in two steps:
> 
> 1) getting the tooling in - essentially copy of src/tools/pgindent with
> changes to paths, exclude patterns, Makefile stuff, etc.

Done already: check out "pgindent" branch on Gitea or GitLab mirrors.

> 2) initial run on the code base - I have no idea how noisy this will get
> at this point. It should be done on all supported branches, otherwise
> it'll make back-patching more difficult.
> 
> I don't think (1) should be committed until there's a clear idea how
> much noise (2) will cause. That is, let's get (1) and (2) ready,
> evaluate the results and then decide if pgindent is the right choice.

You're welcome to continue from where I left and do (2).
It will get noise, but now we have the astyle and clang-format
branches too for comparing and checking the noise difference.

--strk;