[postgis-devel] Code formatting digging in

[Darafei "Komяpa" Praliaskouski]

I'm ok with doing formatting before editing of code, file by file, if that
seems feasible on writing.
I think that thread started with people being unhappy about me doing so.

I have two questions then:

 - do we have to blend into the style of
https://github.com/postgis/postgis/blob/svn-trunk/extensions/address_standardizer/gamma.c#L142
if
editing around it, or there is an option to clean it up before?

 - do we follow the
https://github.com/postgis/postgis/blob/svn-trunk/STYLE#L27, to the letter
or to the spirit?


ср, 28 февр. 2018 г. в 20:25, Regina Obe <lr at pcorp.us>:

> +1 for stop f**king with formatting.
>
>
>
>
>
> *From:* postgis-devel [mailto:postgis-devel-bounces at lists.osgeo.org] *On
> Behalf Of *Bborie Park
> *Sent:* Wednesday, February 28, 2018 11:21 AM
> *To:* PostGIS Development Discussion <postgis-devel at lists.osgeo.org>
> *Subject:* Re: [postgis-devel] Code formatting digging in
>
>
>
> +1 for stop f**king with formatting.
>
>
>
> I wonder when we'll get to debating camel vs snake.
>
> -bborie
>
>
>
> On Feb 28, 2018 08:15, "Paul Ramsey" <pramsey at cleverelephant.ca> wrote:
>
> +1. The issue is additional dependencies and minimal effort for devs
> to create identical results. An embedded formatter like astyle or
> pgindent gives us the easiest way of achieving that. (Another proposed
> solution: stop f___ing with formatting. I know, it's an impossible
> dream.)
>
> P.
>
>
> On Wed, Feb 28, 2018 at 8:09 AM, Sandro Santilli <strk at kbt.io> wrote:
> > On Wed, Feb 28, 2018 at 02:34:08PM +0000, Darafei "Komяpa" Praliaskouski
> wrote:
> >
> >> TLDR: pgindent heavily broken, style ported to clang-format, let's use
> >> clang-format with pgindent style.
> >
> > Maybe you failed to understand the reason "pgindent" was considered
> > better than "clang-format": possibility to shipt the tool with PostGIS.
> >
> > If "pgindent" is broken I suggest to file issues upstream:
> >
> >     https://git.postgresql.org/git/pg_bsd_indent.git
> >
> > According to Tomas this would be the same code as the one also
> > embedded in PostgreSQL, but maybe that's not the case ?
> >
> >     https://github.com/postgres/postgres/tree/master/src/tools/pgindent
> >
> >> Some practices from pgindent and postgres code stylestill can be adopted
> >> though even the tool does not fit. I ported Postgres brace style to
> >> .clang-format in my PR.
> >
> > I really don't care about which style is choosen, as long as we can
> > make it easy for any contributor to produce patches that will meet
> > the criteria our build bots will expect.
> >
> > At the moment the proposed solutions are:
> >
> >      tool              | additional dependencies
> >   ---------------------+-------------------------------------
> >    embedded pgindent   |
> >   ---------------------+-------------------------------------
> >    embedded astyle     | a C++ compiler
> >   ---------------------+-------------------------------------
> >    clang-format        | clang-format of a specific version
> >   ---------------------+-------------------------------------
> >
> > --strk;
> >
> >   ()   Free GIS & Flash consultant/developer
> >   /\   https://strk.kbt.io/services.html
> > _______________________________________________
> > postgis-devel mailing list
> > postgis-devel at lists.osgeo.org
> > https://lists.osgeo.org/mailman/listinfo/postgis-devel
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/postgis-devel
>
>
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/postgis-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/postgis-devel/attachments/20180228/5bc33992/attachment-0001.html>