[postgis-devel] r17005 - Upgrade script generator fix

[Sandro Santilli]

On Mon, Nov 12, 2018 at 11:17:28AM +0000, Darafei wrote:
> Author: komzpa
> Date: 2018-11-12 23:17:28 -0800 (Mon, 12 Nov 2018)
> New Revision: 17005
> 
> Modified:
>    trunk/postgis/postgis.sql.in
>    trunk/utils/postgis_proc_upgrade.pl
> Log:
> Upgrade script generator fix
> 
> References #4230

[...]

> Modified: trunk/utils/postgis_proc_upgrade.pl
> ===================================================================
> --- trunk/utils/postgis_proc_upgrade.pl	2018-11-12 09:16:08 UTC (rev 17004)
> +++ trunk/utils/postgis_proc_upgrade.pl	2018-11-13 07:17:28 UTC (rev 17005)
> @@ -402,7 +402,7 @@
>  					chop $subdefn;
>  					$subdefn =~ s/[,;]$//; # strip ending comma or semicolon
>  					# argument types must be specified in ALTER OPERATOR FAMILY
> -					if ( $subdefn =~ m/\s+(OPERATOR.*)(FOR.*)/ )
> +					if ( $subdefn =~ m/\s+(OPERATOR.*)/ )
>  					{
>  						$subdefn = $1.'('.$opctype.','.$opctype.') '.$2;
>  					}

This change is suspicious. The `$2` reference at the end of
the line in the conditional block is meant to reference the
FOR xxx part, are you sure we dont' want that part here ?

Can you think of a way to automate testing of postgis_restore.pl ?

--strk;