[postgis-devel] [postgis-tickets] r16847 - Revise postgis_extensions_upgrade to repackage raster if it finds it unpackaged. Revise unpackage notice to say to give instruction to call the postgis_extensions_upgrade function and repackage.

[Sandro Santilli]

On Thu, Sep 27, 2018 at 02:50:36AM +0000, Regina Obe wrote:
> Author: robe
> Date: 2018-09-27 14:50:36 -0700 (Thu, 27 Sep 2018)
> New Revision: 16847
> 
> Modified:
>    trunk/extensions/postgis/unpackage_raster_if_needed.sql
>    trunk/postgis/postgis.sql.in
> Log:
> Revise postgis_extensions_upgrade to repackage raster if it finds it unpackaged.  Revise unpackage notice to say to give instruction to call the postgis_extensions_upgrade function and repackage.

I don't like this change.

Reasons:

1. It makes `postgis_extensions_upgrade` function do more than it was
   meant to do (automatically package unpackaged code) and do it partially
   (only does for raster, not for other postgis extensions, and it is not
   documented to do it).

2. It makes life of people who cannot (or don't want to) build PostGIS
   with raster support harder because they cannot re-package raster
   while they could just uninstall the unpackaged via script
   (instructions of doing which were removed in this commit)

3. It asks people to use a function meant to upgrade for doing a
   different thing (repackage) when there's a clean standard syntax
   to do that already.

What was the reason for this change, exactly ? I would revert it.

--strk;