[postgis-devel] jsonb leftovers on upgrade

[Sandro Santilli]

On Fri, Jun 28, 2019 at 09:54:39AM +0200, Sandro Santilli wrote:
> I can get a regression failure with this call:
> 
>     regress/run_test.pl -v \
>         --extension \
>         --upgrade-path unpackaged--3.0.0dev
>         regress/core/regress.sql
> 
> The failures are:
> 
>   +unexpected probin|json:/usr/src/postgis/repository-sync-scripts/postgis/regress/00-regress-install/lib/postgis-3
>   +unexpected probin|jsonb:/usr/src/postgis/repository-sync-scripts/postgis/regress/00-regress-install/lib/postgis-3
>   +unexpected probin|st_asgeojson:/usr/src/postgis/repository-sync-scripts/postgis/regress/00-regress-install/lib/postgis-3
>   [...]
>   ERROR:  cannot drop extension postgis because other objects depend on it
>   DETAIL:  function json(geometry) depends on type geometry
>            function jsonb(geometry) depends on type geometry
>            cast from geometry to json depends on type geometry
>            cast from geometry to jsonb depends on type geometry
>   HINT:  Use DROP ... CASCADE to drop the dependent objects too.
> 
> Now:
> 
>   1. Can anyone reproduce ?
>   2. Why none of our bots catches this ?!
>      Are we out of bots using json?

I found that with upgrade path `unpackaged--3.0.0alpha3dev` things
work correctly, so the above must have been a bug in some previous
3.0.0dev version.

Now this feels *very* confusing, with all thise alpha/beta/rc things.
Shouldn't we just keep using "3.0.0dev" as the version until we go
final, rather than adding alpha/beta/rc in those scripts ? I mean...
do we really want to have upgrade scripts from alpha1 to alpha2 rather
than just the normal dev -> devnext -> dev approach ?

--strk;