[postgis-devel] Remove Comments.sql

Sandro Santilli strk at kbt.io
Wed Dec 16 15:22:29 PST 2020


On Wed, Dec 16, 2020 at 03:14:00PM -0800, Paul Ramsey wrote:
> I would like to remove the dependency that runs from docs->comments.sql->extension, as I don't feel like the in-database comments provide any great utility, and the dependency just makes for really obscure bugs.
> 
> I was testing my st_makeline(x,y,z,srid) addition and tests failed, why? Because the old signatures weren't in the database, but they were in the comments! Because they were in the docs!
> 
> COMMENT
> COMMENT
> psql:/Users/pramsey/Code/postgis-git/regress/00-regress-install/share/contrib/postgis/postgis_comments.sql:58: ERROR:  function st_makepoint(double precision, double precision) does not exist
> 
> Commence the special pleading.

Sounds like a great feature to me ?
The testsuite revealed you that you forgot to update docs...
What's obscure about it ?

--strk;



More information about the postgis-devel mailing list