[postgis-devel] Remove Comments.sql

[Paul Ramsey]

> On Dec 16, 2020, at 3:22 PM, Sandro Santilli <strk at kbt.io> wrote:
> 
> On Wed, Dec 16, 2020 at 03:14:00PM -0800, Paul Ramsey wrote:
>> I would like to remove the dependency that runs from docs->comments.sql->extension, as I don't feel like the in-database comments provide any great utility, and the dependency just makes for really obscure bugs.
>> 
>> I was testing my st_makeline(x,y,z,srid) addition and tests failed, why? Because the old signatures weren't in the database, but they were in the comments! Because they were in the docs!
>> 
>> COMMENT
>> COMMENT
>> psql:/Users/pramsey/Code/postgis-git/regress/00-regress-install/share/contrib/postgis/postgis_comments.sql:58: ERROR:  function st_makepoint(double precision, double precision) does not exist
>> 
>> Commence the special pleading.
> 
> Sounds like a great feature to me ?
> The testsuite revealed you that you forgot to update docs...
> What's obscure about it ?

>> ERROR:  function st_makepoint(double precision, double precision) does not exist

What do you suppose I spent all my time looking at? the docs? no, looking for why this function that I removed is being complained about...

Also, I want to normalize the idea that our docs won't feed into our extension when we change the doco format.

P

> 
> --strk;
> 
> _______________________________________________
> postgis-devel mailing list
> postgis-devel at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/postgis-devel