[postgis-devel] 3.0.1 issues report

[rmrodriguez at carto.com]

On Mon, Jun 22, 2020 at 2:07 AM Greg Troxel <gdt at lexort.com> wrote:
>
> Some progress:
>
>   If pkg-config is not available, then PROJ_LDFLAGS ends up empty
>   instead of -lproj.  However there is no error and proj is reproted
>   found.  I don't see in 2.5->3 NEWS that this is now required.  I don't
>   find that it is required in README.postgis.
>

This is a bug. We use to default to just trying to link to `lproj` if
the projdir wasn't declared, but now we are defaulting to that only if
the directory isn't passed and we have pkg-config but not proj
installed (or proj pre 4.8 is used, since that didn't have pkg-config
files). It is not handling correctly the option where projdir is not
passed and pkg-config isn't installed.


>   Once I added pkg-config (as a declared dependency, making it
>   available), I got a fatal error about json-c, that I also didn't find
>   being a new requirement in NEWS.  In README.postgis it says it is
>   optional.

Another bug. We are using [] to tell PKG_CHECK_MODULES to do nothing
if json-c isn't found via pkg-config, but it interpretes that as "do
the default thing" which is throwing an error.

I've created a PR with both fixes
(https://github.com/postgis/postgis/pull/567) but it's really hard for
me to test this out. I've tested it by removing pkg-config and it
works, but removing json-c gets rid of almost half my OS and breaks
many other things. Could you give it a try, please?

> I wonder if the package should include protobuf-c; it seems useful to
> some and not that big so I will tend to include it.

I've considered removing the dependency and keeping it under dist/
with the pre-generated files and link it statically, but then it makes
updating or using dynamic linking for those to prefer it.


> I wonder if the package should include protobuf-c; it seems useful to
> some and not that big so I will tend to include it.
>



--
Raúl Marín Rodríguez
carto.com