[postgis-devel] protobuf-c configure test dropping LDFLAGS needed for conftest to run

[Sandro Santilli]

Hi Thomas,
thanks for pointing this out, I've also changed the line above
masking CPPFLAGS, with commit 53e6e0c2a94163d185b5b8b558d7780e0f74e710

Does it sound good to you ? It's in the main branch

--strk;

On Sat, Jul 24, 2021 at 03:52:08PM +0200, Dr. Thomas Orgis wrote:
> 
> I'm just dopping by to suggest a change to the configure script to make
> it work in environments where LDFLAGS in the envrionment are actually
> necessary, like some RPATH-related settings in there.
> 
> The strangely elaborate checking of protobuf-c (instead of just being
> content with what pkg-config tells us, like --modversion) wants to run
> the linked conftest binary, which fails to do so because of this:
> 
> (https://git.osgeo.org/gitea/postgis/postgis/src/branch/main/configure.ac line 1035)
> 
>         if test -n "$PROTOBUF_LDFLAGS"; then
> 		LDFLAGS="$PROTOBUF_LDFLAGS"
> 	fi
> 
> I suggest that to be changed to
> 
>         if test -n "$PROTOBUF_LDFLAGS"; then
> 		LDFLAGS="$LDFLAGS $PROTOBUF_LDFLAGS"
> 	fi
> 
> to keep honouring things like -Wl,R/prefix/of/protobuf/lib. With this
> change, I can build postgis on my setup where such is the case.
> 
> 
> Alrighty then,
> 
> Thomas