[postgis-tickets] [PostGIS] #2878: winnie coughing up blood when trying to build cunit for twkb

[PostGIS]

#2878: winnie coughing up blood when trying to build cunit for twkb
----------------------+-----------------------------------------------------
  Reporter:  robe     |       Owner:  nicklas      
      Type:  defect   |      Status:  reopened     
  Priority:  blocker  |   Milestone:  PostGIS 2.2.0
 Component:  postgis  |     Version:  trunk        
Resolution:           |    Keywords:               
----------------------+-----------------------------------------------------

Comment(by nicklas):

 Yes, I guess you are right.

 The reason for moving the functions into the header file was that I saw a
 performance regression when they were in a separate file compared to when
 they were in the lwout_twkb.c file.

 The timing on a known data set and query, went from in average about 2850
 ms to above 3000 ms. I recompiled and tested back and forward a few times.
 So it is about 5%.
 When putting the functions into the header the timings was almost back
 where we began.

 But I think I will have to rewind to the version Sandro wrote with the
 functions in a varint.c file and take the performance impact.

 This is clearly a grey zone where the compilers doesn't fully agree. I
 guess it can be some setting in the config file that gives this
 difference?

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/2878#comment:14>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.