[postgis-tickets] [PostGIS] #3037: Sort out CFLAGS differences in raster/rt_pg and liblwgeom/

[PostGIS]

#3037: Sort out CFLAGS differences in raster/rt_pg and liblwgeom/
-----------------------------------+----------------------------------------
 Reporter:  strk                   |       Owner:  strk         
     Type:  defect                 |      Status:  new          
 Priority:  medium                 |   Milestone:  PostGIS 2.2.0
Component:  build/upgrade/install  |     Version:  trunk        
 Keywords:                         |  
-----------------------------------+----------------------------------------
 Looking at compiler warnings it came to my attention that some warnings
 are only output under raster/rt_pg. On a closer look, the compiler flags
 used there and in liblwgeom (for example) are different !

 Here's the build line for raster/rt_pg/rtpostgis.c:
 {{{
 gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-
 statement -Wendif-labels -Wmissing-format-attribute -Wformat-security
 -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -fpic
 -I/usr/local/include  -I/usr/include/libxml2 -I/usr/local/include
 -DHAVE_SFCGAL    "-I../../liblwgeom" -I/usr/local/include
 "-I../../libpgcommon"  -I../rt_core -I. -I.
 -I/home/postgresql-9.3.4/include/server
 -I/home/postgresql-9.3.4/include/internal -D_GNU_SOURCE
 -I/usr/include/libxml2   -c -o rtpostgis.o rtpostgis.c
 }}}

 And here's the one for liblwgeom/lwutil.c:
 {{{
 /bin/bash ../libtool --mode=compile gcc -g -O2  -fPIC -DPIC  -Wall
 -Wmissing-prototypes -I/usr/local/include   -I/usr/local/include
 -DHAVE_SFCGAL -c -o lwutil.lo lwutil.c
 libtool: compile:  gcc -g -O2 -fPIC -DPIC -Wall -Wmissing-prototypes
 -I/usr/local/include -I/usr/local/include -DHAVE_SFCGAL -c lwutil.c  -fPIC
 -DPIC -o .libs/lwutil.o
 }}}

 There's definitely something missing (warning flags, mostly) in liblwgeom.

 Note that the liblwgeom issue is not libtool related as you can see from
 the build line for loader/shp2pgsql-core.c:
 {{{
 gcc -I ../liblwgeom -g -O2  -fPIC -DPIC  -Wall -Wmissing-prototypes    -c
 shp2pgsql-core.c
 }}}

-- 
Ticket URL: <http://trac.osgeo.org/postgis/ticket/3037>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.