[postgis-tickets] r14416 - remove inaccurate comments (the tests are always performed, and we're calculating a box if we don't have one)

Sandro Santilli strk at keybit.net
Sun Nov 22 06:39:54 PST 2015


On Sun, Nov 22, 2015 at 06:26:47AM -0800, Daniel Baston wrote:
> Author: dbaston
> Date: 2015-11-22 06:26:47 -0800 (Sun, 22 Nov 2015)
> New Revision: 14416
> 
> Modified:
>    trunk/postgis/lwgeom_geos.c
> Log:
> remove inaccurate comments (the tests are always performed, and we're calculating a box if we don't have one)
>  	/*
>  	 * short-circuit 1: if geom2 bounding box does not overlap
>  	 * geom1 bounding box we can prematurely return FALSE.
> -	 * Do the test IFF BOUNDING BOX AVAILABLE.
>  	 */
>  	if ( gserialized_get_gbox_p(geom1, &box1) &&
>  	        gserialized_get_gbox_p(geom2, &box2) )

I think the comment may also refer to a BOX not being available due
to the geometry being EMPTY (empty geoms have no bbox).

--strk;


More information about the postgis-tickets mailing list