[postgis-tickets] [PostGIS] #3604: pgcommon/Makefile.in orders CFLAGS incorrectly leading to wrong liblwgeom.h

[PostGIS]

#3604: pgcommon/Makefile.in orders CFLAGS incorrectly leading to wrong liblwgeom.h
------------------------------------+---------------------------
  Reporter:  gdt                    |      Owner:  strk
      Type:  defect                 |     Status:  closed
  Priority:  medium                 |  Milestone:  PostGIS 2.2.3
 Component:  build/upgrade/install  |    Version:  trunk
Resolution:  fixed                  |   Keywords:
------------------------------------+---------------------------
Changes (by robe):

 * milestone:  PostGIS 2.3.0 => PostGIS 2.2.3


Comment:

 I was having this issue on FreeBSD because I think the postgis 2.3
 liblwgeom I just installed was trying to be used by the 2.2 I was trying
 to compile.

 The error looked like this:


 {{{
 rtpg_geometry.c:105:42: error: too many arguments to function call,
 expected 2, have 3

         gser = gserialized_from_lwgeom(geom, 0, &gser_size);

                ~~~~~~~~~~~~~~~~~~~~~~~          ^~~~~~~~~~

 /usr/local/include/liblwgeom.h:1957:1: note: 'gserialized_from_lwgeom'
 declared here

 extern GSERIALIZED* gserialized_from_lwgeom(LWGEOM *geom, size_t *size);

 ^

 rtpg_geometry.c:184:42: error: too many arguments to function call,
 expected 2, have 3

         gser = gserialized_from_lwgeom(geom, 0, &gser_size);

                ~~~~~~~~~~~~~~~~~~~~~~~          ^~~~~~~~~~

 /usr/local/include/liblwgeom.h:1957:1: note: 'gserialized_from_lwgeom'
 declared here

 extern GSERIALIZED* gserialized_from_lwgeom(LWGEOM *geom, size_t *size);

 ^

 rtpg_geometry.c:326:81: error: too many arguments to function call,
 expected 2, have 3

                 gser =
 gserialized_from_lwgeom(lwpoly_as_lwgeom(geomval2[call_cntr].geom), 0,
 &gser_size);

                        ~~~~~~~~~~~~~~~~~~~~~~~
 ^~~~~~~~~~

 /usr/local/include/liblwgeom.h:1957:1: note: 'gserialized_from_lwgeom'
 declared here

 extern GSERIALIZED* gserialized_from_lwgeom(LWGEOM *geom, size_t *size);

 ^

 rtpg_geometry.c:628:59: error: too many arguments to function call,
 expected 2, have 3

                 gser = gserialized_from_lwgeom(pix2[call_cntr].geom, 0,
 &gser_size);

                        ~~~~~~~~~~~~~~~~~~~~~~~
 ^~~~~~~~~~

 /usr/local/include/liblwgeom.h:1957:1: note: 'gserialized_from_lwgeom'
 declared here

 extern GSERIALIZED* gserialized_from_lwgeom(LWGEOM *geom, size_t *size);

 ^

 4 errors generated.

 gmake[3]: *** [<builtin>: rtpg_geometry.o] Error 1

 gmake[3]: Leaving directory
 '/usr/home/robe/sources/postgis-2.2.2/raster/rt_pg'

 gmake[2]: *** [Makefile:28: pglib] Error 2

 gmake[2]: Leaving directory '/usr/home/robe/sources/postgis-2.2.2/raster'

 gmake[1]: *** [GNUmakefile:16: all] Error 1

 gmake[1]: Leaving directory '/usr/home/robe/sources/postgis-2.2.2'

 *** Error code 2
 }}}

 This patch fixed the issue after I committed to 2.2, thanks Greg.

--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/3604#comment:6>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.