[postgis-tickets] r16570 - Wrong code-comment regarding front/back of BOX3D

Darafei komzpa at gmail.com
Thu May 10 01:07:13 PDT 2018


Author: komzpa
Date: 2018-05-10 01:07:13 -0700 (Thu, 10 May 2018)
New Revision: 16570

Modified:
   trunk/NEWS
   trunk/postgis/lwgeom_box3d.c
Log:
Wrong code-comment regarding front/back of BOX3D

Patch by Matthias Bay

Closes #4084
Closes https://github.com/postgis/postgis/pull/241


Modified: trunk/NEWS
===================================================================
--- trunk/NEWS	2018-05-09 10:21:03 UTC (rev 16569)
+++ trunk/NEWS	2018-05-10 08:07:13 UTC (rev 16570)
@@ -69,6 +69,7 @@
   - #4080, Add external raster band index to ST_BandMetaData
   - Add Raster Tips section to Documentation for information about
     Raster behavior (e.g. Out-DB performance, maximum open files)
+  - #4084: Fixed wrong code-comment regarding front/back of BOX3D (Matthias Bay)
 
 PostGIS 2.4.0
 2017/09/30

Modified: trunk/postgis/lwgeom_box3d.c
===================================================================
--- trunk/postgis/lwgeom_box3d.c	2018-05-09 10:21:03 UTC (rev 16569)
+++ trunk/postgis/lwgeom_box3d.c	2018-05-10 08:07:13 UTC (rev 16570)
@@ -333,10 +333,10 @@
 		/* add right polygon */
 		geoms[3] = lwpoly_as_lwgeom(lwpoly_construct_rectangle(LW_TRUE, LW_FALSE,
 				   	&points[3], &points[2], &points[6], &points[7]));
-		/* add back polygon */
+		/* add front polygon */
 		geoms[4] = lwpoly_as_lwgeom(lwpoly_construct_rectangle(LW_TRUE, LW_FALSE,
 				   	&points[0], &points[3], &points[7], &points[4]));
-		/* add front polygon */
+		/* add back polygon */
 		geoms[5] = lwpoly_as_lwgeom(lwpoly_construct_rectangle(LW_TRUE, LW_FALSE,
 				   	&points[1], &points[5], &points[6], &points[2]));
 



More information about the postgis-tickets mailing list