[postgis-tickets] [PostGIS] #4213: Use TupleDescAttr to access tupdesc attributes

PostGIS trac at osgeo.org
Wed Oct 24 00:59:06 PDT 2018


#4213: Use TupleDescAttr to access tupdesc attributes
-------------------------+---------------------------
 Reporter:  Algunenano   |      Owner:  Algunenano
     Type:  enhancement  |     Status:  assigned
 Priority:  medium       |  Milestone:  PostGIS 3.0.0
Component:  postgis      |    Version:  trunk
 Keywords:               |
-------------------------+---------------------------
 Comes from
 https://github.com/CartoDB/odbc_fdw/commit/244fae80ae6f9aefb5681ddaab99e5181595c21d#r30945886
 {{{
 This really should use TupleDescAttr(), not hardcode the access. It's been
 backpatched (with the appriiate definition), too. If you want to support
 older minor versions, just define it yourself.
 }}}

 Defined in tupdesc.h
 {{{
 #define TupleDescAttr(tupdesc, i) (&(tupdesc)->attrs[(i)])
 }}}

 Direct access is being used currently in, at least, these places:
 postgis/geobuf.c (61, 131)
 postgis/mvt.c (338)

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4213>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.


More information about the postgis-tickets mailing list