[postgis-tickets] [PostGIS] #4334: Can't upgrade with a view based on ST_AsMVTGeom

[PostGIS]

#4334: Can't upgrade with a view based on ST_AsMVTGeom
------------------------------------+---------------------------
  Reporter:  Algunenano             |      Owner:  strk
      Type:  defect                 |     Status:  new
  Priority:  high                   |  Milestone:  PostGIS 2.4.7
 Component:  build/upgrade/install  |    Version:  2.4.x
Resolution:                         |   Keywords:
------------------------------------+---------------------------

Comment (by Algunenano):

 > 1) Rename the function to be clear about _which_ condition we're
 checking (or more genererically what's the goal, like
 "_postgis_drop_function_if_needed")

 Makes sense.

 > 2) Pass the new signature to the function ? (or how can it tell whether
 it is needed to drop it or not ? That depends on the new function
 signature, right ?)

 The idea is that you pass the complete signature of the old function and
 it will only try to drop it if it matches the one installed, so passing
 the new signature isn't necessary.

 > 3) Integrate the function in the postgis upgrade function (implies using
 the function from postgis_drop_before.sql file

 That's the idea. I'm thinking on creating this auxiliar function and use
 it to drop the functions in  `postgis_drop_before.sql`.

 > 4 4) Integrate tests (could be useful to do something in sub
 create_upgrade_test_objects of run_test.pl, or further generalize that to
 find things to do in a pre-upgrade.sql script)

 Automating this for all functions looks really complex, but I can probably
 hook the view tests I did above.

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4334#comment:5>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.