[postgis-tickets] r17949 - Revert r17929

[Raul]

Author: algunenano
Date: 2019-10-17 11:09:19 -0700 (Thu, 17 Oct 2019)
New Revision: 17949

Modified:
   branches/2.3/NEWS
   branches/2.3/postgis/Makefile.in
   branches/2.3/postgis/postgis.sql.in
   branches/2.3/raster/rt_pg/Makefile.in
   branches/2.3/raster/rt_pg/rtpostgis.sql.in
Log:
Revert r17929

References #4546


Modified: branches/2.3/NEWS
===================================================================
--- branches/2.3/NEWS	2019-10-17 18:08:35 UTC (rev 17948)
+++ branches/2.3/NEWS	2019-10-17 18:09:19 UTC (rev 17949)
@@ -13,7 +13,6 @@
   - #4534, Fix leak in lwcurvepoly_from_wkb_state (Raúl Marín)
   - #4536, Fix leak in lwcollection_from_wkb_state (Raúl Marín)
   - #4537, Fix leak in WKT collection parser (Raúl Marín)
-  - #4546, Fix ST_ConcaveHull under FDW (Raúl Marín)
   - #4547, Fix AddRasterConstraints handling of empty tables (Sandro Santilli)
 
 PostGIS 2.3.10

Modified: branches/2.3/postgis/Makefile.in
===================================================================
--- branches/2.3/postgis/Makefile.in	2019-10-17 18:08:35 UTC (rev 17948)
+++ branches/2.3/postgis/Makefile.in	2019-10-17 18:09:19 UTC (rev 17949)
@@ -175,7 +175,7 @@
 # replace @extschema at . with nothing, this is only used as placeholder for extension install
 %.sql: %.sql.in
 	$(SQLPP) -I../libpgcommon $< | grep -v '^#' | \
-	$(PERL) -lpe "s'MODULE_PATHNAME'\$$libdir/postgis- at POSTGIS_MAJOR_VERSION@. at POSTGIS_MINOR_VERSION@'g;s'@extschema@\.''g;s'SET search_path = @extschema@''g;" > $@
+	$(PERL) -lpe "s'MODULE_PATHNAME'\$$libdir/postgis- at POSTGIS_MAJOR_VERSION@. at POSTGIS_MINOR_VERSION@'g;s'@extschema@\.''g" > $@
 
 postgis_upgrade_for_extension.sql: postgis_drop_before.sql postgis_upgrade_for_extension.sql.in postgis_drop_after.sql
 	cat $^ > $@

Modified: branches/2.3/postgis/postgis.sql.in
===================================================================
--- branches/2.3/postgis/postgis.sql.in	2019-10-17 18:08:35 UTC (rev 17948)
+++ branches/2.3/postgis/postgis.sql.in	2019-10-17 18:09:19 UTC (rev 17949)
@@ -5132,7 +5132,7 @@
 
 	geom := @extschema at .ST_BuildArea(mline);
 
-	IF @extschema at .GeometryType(geom) != 'POLYGON'
+	IF GeometryType(geom) != 'POLYGON'
 	THEN
 		RAISE EXCEPTION 'Input returns more then a single polygon, try using BdMPolyFromText instead';
 	END IF;
@@ -5140,8 +5140,7 @@
 	RETURN geom;
 END;
 $$
-LANGUAGE 'plpgsql' IMMUTABLE STRICT _PARALLEL
-SET search_path = @extschema@;
+LANGUAGE 'plpgsql' IMMUTABLE STRICT _PARALLEL;
 
 --
 -- SFSQL 1.1
@@ -5178,8 +5177,7 @@
 	RETURN geom;
 END;
 $$
-LANGUAGE 'plpgsql' IMMUTABLE STRICT _PARALLEL
-SET search_path = @extschema@;
+LANGUAGE 'plpgsql' IMMUTABLE STRICT _PARALLEL;
 
 /* Should we include the .sql directly here ? */
 #include "long_xact.sql.in"
@@ -5678,8 +5676,7 @@
 
 	END;
 $$
-  LANGUAGE plpgsql IMMUTABLE STRICT _PARALLEL
-  SET search_path = @extschema@;
+  LANGUAGE plpgsql IMMUTABLE STRICT _PARALLEL;
 
 CREATE OR REPLACE FUNCTION ST_ConcaveHull(param_geom geometry, param_pctconvex float, param_allow_holes boolean DEFAULT false) RETURNS geometry AS
 $$
@@ -5834,7 +5831,6 @@
 	END;
 $$
 LANGUAGE 'plpgsql' IMMUTABLE STRICT _PARALLEL;
-SET search_path = @extschema@;
 -- ST_ConcaveHull and Helper functions end here --
 
 -----------------------------------------------------------------------

Modified: branches/2.3/raster/rt_pg/Makefile.in
===================================================================
--- branches/2.3/raster/rt_pg/Makefile.in	2019-10-17 18:08:35 UTC (rev 17948)
+++ branches/2.3/raster/rt_pg/Makefile.in	2019-10-17 18:09:19 UTC (rev 17949)
@@ -102,7 +102,7 @@
 # replace @extschema at . with nothing, this is only used as placeholder for extension install
 %.sql: %.sql.in
 	$(SQLPP) -I../../postgis/ -I../../ $< | grep -v '^#' | \
-	$(PERL) -lpe "s'MODULE_PATHNAME'\$$libdir/rtpostgis- at POSTGIS_MAJOR_VERSION@. at POSTGIS_MINOR_VERSION@'g;s'@extschema@\.''g;s'SET search_path = @extschema@''g;" > $@
+	$(PERL) -lpe "s'MODULE_PATHNAME'\$$libdir/rtpostgis- at POSTGIS_MAJOR_VERSION@. at POSTGIS_MINOR_VERSION@'g;s'@extschema@\.''g" > $@
 
 rtpostgis_for_extension.sql: rtpostgis.sql.in
 	$(SQLPP) -I../../postgis/ -I../../ $< | grep -v '^#' | \

Modified: branches/2.3/raster/rt_pg/rtpostgis.sql.in
===================================================================
--- branches/2.3/raster/rt_pg/rtpostgis.sql.in	2019-10-17 18:08:35 UTC (rev 17948)
+++ branches/2.3/raster/rt_pg/rtpostgis.sql.in	2019-10-17 18:09:19 UTC (rev 17949)
@@ -2341,8 +2341,7 @@
 
 		RETURN @extschema at ._ST_asraster(g, scale_x, scale_y, NULL, NULL, $3, $4, $5, NULL, NULL, ul_x, ul_y, skew_x, skew_y, $6);
 	END;
-	$$ LANGUAGE 'plpgsql' STABLE
-	SET search_path = @extschema@;
+	$$ LANGUAGE 'plpgsql' STABLE;
 
 CREATE OR REPLACE FUNCTION st_asraster(
 	geom geometry,
@@ -7396,8 +7395,7 @@
 		RETURN  @extschema at ._add_raster_constraint(cn, sql);
 	END;
 	$$ LANGUAGE 'plpgsql' VOLATILE STRICT
-	COST 100
-	SET search_path = @extschema@;
+	COST 100;
 
 CREATE OR REPLACE FUNCTION _drop_raster_constraint_coverage_tile(rastschema name, rasttable name, rastcolumn name)
 	RETURNS boolean AS
@@ -8747,8 +8745,7 @@
 
   RETURN;
 END;
-$$ LANGUAGE 'plpgsql' STABLE STRICT
-SET search_path = @extschema@;
+$$ LANGUAGE 'plpgsql' STABLE STRICT;
 
 ------------------------------------------------------------------------------
 -- ST_CreateOverview