[postgis-tickets] [PostGIS] #4483: Can't upgrade from PostGIS 3.0.0alpha3 to 3.0.0alpha4 or 3.0.0alpha5dev (ST_AsGeoJSON)

[PostGIS]

#4483: Can't upgrade from PostGIS 3.0.0alpha3 to 3.0.0alpha4 or 3.0.0alpha5dev
(ST_AsGeoJSON)
----------------------+---------------------------
  Reporter:  robe     |      Owner:  pramsey
      Type:  defect   |     Status:  reopened
  Priority:  blocker  |  Milestone:  PostGIS 3.0.1
 Component:  postgis  |    Version:  master
Resolution:           |   Keywords:
----------------------+---------------------------

Comment (by strk):

 There are many versions of that function that I see in git log:

 Removed by commit [aafcb2e8ef797be6537f160dc321396a6fb5c8c9/git]:
 > ST_AsGeoJson(geom geometry, maxdecimaldigits int4 DEFAULT 15, options
 int4 DEFAULT 0)

 Removed by commit [2034809342c06295428fef80616cfa02d46126eb/git]:
 > r record, geom_column text DEFAULT '', maxdecimaldigits int4 DEFAULT 15,
 pretty_print bool DEFAULT false

 Removed by commit [ce70e49067618cdfb7224ce5de2a69d56e6130ae/git]:
 > _ST_AsGeoJson(int4, geometry, int4, int4)
 > ST_AsGeoJson(gj_version int4, geog geography, maxdecimaldigits int4
 DEFAULT 15, options int4 DEFAULT 0)
 Both are currently removed in postgis_after_upgrade.sql

 If the above is correct then the commit in r17879 should just be reverted
 as there's never been a default-less version taking a record as first
 argument ? Also we should probably add a drop for the very first one or it
 will be kept around.

 Also I noticed we have a couple of the removed functions in legacy.sql,
 does it make sense to have things both in postgis_after/before_upgrade and
 in legacy.sql ?

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4483#comment:35>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.