[postgis-tickets] [PostGIS] #4845: PostGIS 3.2 fails compile against PostgreSQL 14 gserialized

[PostGIS]

#4845: PostGIS 3.2 fails compile against PostgreSQL 14 gserialized
---------------------+---------------------------
 Reporter:  robe     |      Owner:  pramsey
     Type:  defect   |     Status:  new
 Priority:  medium   |  Milestone:  PostGIS 3.2.0
Component:  postgis  |    Version:  master
 Keywords:           |
---------------------+---------------------------
 I thought it was time to put debbie to testing PG14 and well bah humbug.


 {{{
 13:07:50 gserialized_supportfn.c: In function ‘postgis_index_supportfn’:
 13:07:50 gserialized_supportfn.c:420:40: warning: passing argument 1 of
 ‘is_pseudo_constant_for_index’ from incompatible pointer type
 [-Wincompatible-pointer-types]
 13:07:50   420 |      if (!is_pseudo_constant_for_index((Node*)expandexpr,
 req->index))
 13:07:50       |                                        ^~~~~~~~~~~~~~~~~
 13:07:50       |                                        |
 13:07:50       |                                        Node * {aka struct
 Node *}
 13:07:50 In file included from gserialized_supportfn.c:38:
 13:07:50
 /var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server/optimizer/optimizer.h:100:55:
 note: expected ‘PlannerInfo *’ {aka ‘struct PlannerInfo *’} but argument
 is of type ‘Node *’ {aka ‘struct Node *’}
 13:07:50   100 | extern bool is_pseudo_constant_for_index(PlannerInfo
 *root, Node *expr,
 13:07:50       |
 ~~~~~~~~~~~~~^~~~
 13:07:50 gserialized_supportfn.c:420:62: warning: passing argument 2 of
 ‘is_pseudo_constant_for_index’ from incompatible pointer type
 [-Wincompatible-pointer-types]
 13:07:50   420 |      if (!is_pseudo_constant_for_index((Node*)expandexpr,
 req->index))
 13:07:50       |
 ~~~^~~~~~~
 13:07:50       |
 |
 13:07:50       |
 struct IndexOptInfo *
 13:07:50 In file included from gserialized_supportfn.c:38:
 13:07:50
 /var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server/optimizer/optimizer.h:100:67:
 note: expected ‘Node *’ {aka ‘struct Node *’} but argument is of type
 ‘struct IndexOptInfo *’
 13:07:50   100 | extern bool is_pseudo_constant_for_index(PlannerInfo
 *root, Node *expr,
 13:07:50       |
 ~~~~~~^~~~
 13:07:50 gserialized_supportfn.c:420:11: error: too few arguments to
 function ‘is_pseudo_constant_for_index’
 13:07:50   420 |      if (!is_pseudo_constant_for_index((Node*)expandexpr,
 req->index))
 13:07:50       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
 13:07:50 In file included from gserialized_supportfn.c:38:
 13:07:50
 /var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server/optimizer/optimizer.h:100:13:
 note: declared here
 13:07:50   100 | extern bool is_pseudo_constant_for_index(PlannerInfo
 *root, Node *expr,
 13:07:50       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
 13:07:50 gserialized_supportfn.c:443:40: warning: passing argument 1 of
 ‘is_pseudo_constant_for_index’ from incompatible pointer type
 [-Wincompatible-pointer-types]
 13:07:50   443 |      if (!is_pseudo_constant_for_index(rightarg,
 req->index))
 13:07:50       |                                        ^~~~~~~~
 13:07:50       |                                        |
 13:07:50       |                                        Node * {aka struct
 Node *}
 13:07:50 In file included from gserialized_supportfn.c:38:
 13:07:50
 /var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server/optimizer/optimizer.h:100:55:
 note: expected ‘PlannerInfo *’ {aka ‘struct PlannerInfo *’} but argument
 is of type ‘Node *’ {aka ‘struct Node *’}
 13:07:50   100 | extern bool is_pseudo_constant_for_index(PlannerInfo
 *root, Node *expr,
 13:07:50       |
 ~~~~~~~~~~~~~^~~~
 13:07:50 gserialized_supportfn.c:443:53: warning: passing argument 2 of
 ‘is_pseudo_constant_for_index’ from incompatible pointer type
 [-Wincompatible-pointer-types]
 13:07:50   443 |      if (!is_pseudo_constant_for_index(rightarg,
 req->index))
 13:07:50       |
 ~~~^~~~~~~
 13:07:50       |                                                     |
 13:07:50       |
 struct IndexOptInfo *
 13:07:50 In file included from gserialized_supportfn.c:38:
 13:07:50
 /var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server/optimizer/optimizer.h:100:67:
 note: expected ‘Node *’ {aka ‘struct Node *’} but argument is of type
 ‘struct IndexOptInfo *’
 13:07:50   100 | extern bool is_pseudo_constant_for_index(PlannerInfo
 *root, Node *expr,
 13:07:50       |
 ~~~~~~^~~~
 13:07:50 gserialized_supportfn.c:443:11: error: too few arguments to
 function ‘is_pseudo_constant_for_index’
 13:07:50   443 |      if (!is_pseudo_constant_for_index(rightarg,
 req->index))
 13:07:50       |           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
 13:07:50 In file included from gserialized_supportfn.c:38:
 13:07:50
 /var/lib/jenkins/workspace/pg/rel/pg14w64/include/postgresql/server/optimizer/optimizer.h:100:13:
 note: declared here
 13:07:50   100 | extern bool is_pseudo_constant_for_index(PlannerInfo
 *root, Node *expr,
 13:07:50       |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
 13:07:50 make[1]: *** [<builtin>: gserialized_supportfn.o] Error 1
 13:07:50 make[1]: Leaving directory
 '/var/lib/jenkins/workspace/postgis/branches/3.2/postgis'
 13:07:50 make: *** [GNUmakefile:22: all] Error 1
 13:07:50 Build step 'Execute shell' marked build as failure
 13:07:50 Triggering a new build of PostgreSQL stop
 13:07:50 Finished: FAILURE
 }}}

-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/4845>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.