[postgis-tickets] [PostGIS] #5261: PostgreSQL 16 GUC changes breaks compile

[PostGIS]

#5261: PostgreSQL 16 GUC changes breaks compile
---------------------+---------------------------
 Reporter:  robe     |      Owner:  pramsey
     Type:  defect   |     Status:  new
 Priority:  blocker  |  Milestone:  PostGIS 3.4.0
Component:  postgis  |    Version:  master
 Keywords:  PG16     |
---------------------+---------------------------
 Both berrie32 and debbie's PG16 run are showing this error:


 {{{
 22:06:19 make[1]: Entering directory
 '/var/lib/jenkins/workspace/postgis/branches/3.4/libpgcommon'
 22:06:19 gcc -I./../liblwgeom -I../liblwgeom
 -I/var/lib/jenkins/workspace/geos/rel-3.11w64/include
 -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG
 -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -Wall
 -I/var/lib/jenkins/workspace/pg/rel/pg16w64/include/postgresql/server
 -fPIC -DPIC  -c -o gserialized_gist.o gserialized_gist.c
 22:06:19 gcc -I./../liblwgeom -I../liblwgeom
 -I/var/lib/jenkins/workspace/geos/rel-3.11w64/include
 -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG
 -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -Wall
 -I/var/lib/jenkins/workspace/pg/rel/pg16w64/include/postgresql/server
 -fPIC -DPIC  -c -o lwgeom_transform.o lwgeom_transform.c
 22:06:20 gcc -I./../liblwgeom -I../liblwgeom
 -I/var/lib/jenkins/workspace/geos/rel-3.11w64/include
 -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG
 -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -Wall
 -I/var/lib/jenkins/workspace/pg/rel/pg16w64/include/postgresql/server
 -fPIC -DPIC  -c -o lwgeom_cache.o lwgeom_cache.c
 22:06:20 gcc -I./../liblwgeom -I../liblwgeom
 -I/var/lib/jenkins/workspace/geos/rel-3.11w64/include
 -I/usr/include/libxml2 -I/usr/include -I/usr/include/json-c  -DNDEBUG
 -std=gnu99 -g -O2 -fno-math-errno -fno-signed-zeros -Wall
 -I/var/lib/jenkins/workspace/pg/rel/pg16w64/include/postgresql/server
 -fPIC -DPIC  -c -o lwgeom_pg.o lwgeom_pg.c
 22:06:20 lwgeom_pg.c: In function ‘postgis_guc_find_option’:
 22:06:20 lwgeom_pg.c:505:13: error: too few arguments to function
 ‘get_guc_variables’
 22:06:20   505 |    (void *) get_guc_variables(),
 22:06:20       |             ^~~~~~~~~~~~~~~~~
 22:06:20 In file included from lwgeom_pg.c:30:
 22:06:20
 /var/lib/jenkins/workspace/pg/rel/pg16w64/include/postgresql/server/utils/guc_tables.h:296:32:
 note: declared here
 22:06:20   296 | extern struct config_generic **get_guc_variables(int
 *num_vars);
 22:06:20       |                                ^~~~~~~~~~~~~~~~~
 22:06:20 lwgeom_pg.c:506:4: warning: implicit declaration of function
 ‘GetNumConfigOptions’; did you mean ‘GetConfigOption’? [-Wimplicit-
 function-declaration]
 22:06:20   506 |    GetNumConfigOptions(),
 22:06:20       |    ^~~~~~~~~~~~~~~~~~~
 22:06:20       |    GetConfigOption
 22:06:20 make[1]: *** [Makefile:69: lwgeom_pg.o] Error 1
 22:06:20 make[1]: Leaving directory
 '/var/lib/jenkins/workspace/postgis/branches/3.4/libpgcommon'
 22:06:20 make: *** [GNUmakefile:25: all] Error 1
 22:06:21 Build step 'Execute shell' marked build as failure
 22:06:21 Triggering a new build of PostgreSQL stop
 22:06:21 Finished: FAILURE
 }}}
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5261>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.