[postgis-tickets] [PostGIS] #5264: make install error when compiling from source while processing 'topology' subdirectory for version > 3.1.7

[PostGIS]

#5264: make install error when compiling from source while processing 'topology'
subdirectory for version > 3.1.7
-----------------------+-----------------------------------------
  Reporter:  louisd    |      Owner:  strk
      Type:  defect    |     Status:  new
  Priority:  medium    |  Milestone:  PostGIS 3.3.2
 Component:  topology  |    Version:  3.3.x
Resolution:            |   Keywords:  make install topology error
-----------------------+-----------------------------------------
Comment (by louisd):

 A little more digging. Here is a diff of a modification I made to
 topologu/Makefile that fixes the problem (at least for me):


 {{{
 bash-5.1# diff Makefile.ori Makefile
 --- Makefile.ori
 +++ Makefile
 @@ -71,12 +71,13 @@
  # NO_TEMP_INSTALL is a workaround for a 9.5dev bug. See:
  # http://www.postgresql.org/message-id/CAB7nPqTsR5o3g-
 fBi6jbsVdhfPiLFWQ_0cGU5=94Rv_8W3qvFA at mail.gmail.com
  NO_TEMP_INSTALL=yes
 -include $(PGXS)

  top_builddir = ..
  VPATH := .
  INSTALL = /usr/bin/install -c
 -LIBTOOL = $(SHELL) $(top_builddir)/libtool
 +LIBTOOL := $(SHELL) $(top_builddir)/libtool
 +
 +include $(PGXS)

  # Set PERL _after_ the include of PGXS
  PERL=/usr/bin/perl
 }}}

 Basically move "include $(PGXS)" after the variables INSTALL and LIBTOOL
 are declared. And also define LIBTOOL := instead of LIBTOOL = since
 $(top_builddir) gets redefined in
 /usr/local/pgsql/lib/pgxs/src/makefiles/pgxs.mk (line 86), and using :=
 instead of = solves this. I guess you could put LIBTOOL = $(SHELL)
 ../libtool instead of defining a variable and then using it.

 This fixes my issue, but I wonder if it creates new problems.
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5264#comment:7>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.