[postgis-tickets] [PostGIS] #5486: Upgrade from 3.2.1 fails due to deprecating two flavors of st_dwithin

[PostGIS]

#5486: Upgrade from 3.2.1  fails due to deprecating two flavors of st_dwithin
-----------------------------------+---------------------------
 Reporter:  strk                   |      Owner:  strk
     Type:  defect                 |     Status:  new
 Priority:  medium                 |  Milestone:  PostGIS 3.3.5
Component:  build/upgrade/install  |    Version:  3.3.x
 Keywords:                         |
-----------------------------------+---------------------------
 Going from 3.2.1 to 3.4.0 the upgrade script attempts to deprecate two
 versions of st_dwithin, resulting in the second deprecation failing
 because the name of the target renamed function is already taken.

 {{{
 # regress/run_test.pl \
   --after-upgrade-script regress/hooks/hook-after-upgrade.sql \
   --after-upgrade-script raster/test/regress/hooks/hook-after-upgrade-
 raster.sql \
   --before-upgrade-script raster/test/regress/hooks/hook-before-upgrade-
 raster.sql \
   --before-upgrade-script regress/hooks/hook-before-upgrade.sql \
   --raster -v --extension \
   --upgrade-path 3.2.1--3.3.3 \
   raster/test/regress/rt_count

 WARNING:  Deprecated function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) left
 behind: cannot drop function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) because
 other objects depend on it
 DETAIL:  view upgrade_view_test_dwithin depends on function
 st_dwithin_deprecated_by_postgis_300(text,text,double precision)
 HINT:  Replace the view changing all occurrences of
 st_dwithin_deprecated_by_postgis_300(text,text,double precision) in its
 definition with st_dwithin and upgrade again
 ERROR:  Attempting to rename replaced function st_dwithin(text, text,
 float8) got function st_dwithin_deprecated_by_postgis_300(text, text,
 double precision) already exists in schema "public" (42723)
 }}}

 The same error occurs upgrading to 3.4.0
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5486>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.