[postgis-tickets] [PostGIS] #5545: Postgis upgrade from 3.2.3 to 3.3.2 failing on create or update function st_orderingequals

[PostGIS]

#5545: Postgis upgrade from 3.2.3 to 3.3.2 failing on create or update function
st_orderingequals
------------------------------------+---------------------------
  Reporter:  robe                   |      Owner:  strk
      Type:  defect                 |     Status:  new
  Priority:  blocker                |  Milestone:  PostGIS 3.3.5
 Component:  build/upgrade/install  |    Version:  3.4.x
Resolution:                         |   Keywords:  pgextwlist
------------------------------------+---------------------------
Comment (by strk):

 The {{{ ALTER EXTENSION postgis }}} statement only affects the "postgis"
 extension, while the {{{ SELECT postgis_extensions_upgrade(); }}} attempts
 to deal with all extentions being part of the core PostGIS distribution,
 and also tries to _package_ support functions that are present in the
 database but not yet part of an extension.

 In your case, the _raster_ support functions are found in the database but
 are not packaged. This was probably the result of updating PostGIS
 extension from a version older than 3.0.0 which is the version in which
 raster support was moved out of the "postgis" extension and in its own
 "postgis_raster" extension.

 Now, if you don't need raster, what you want to do is DROP the raster
 support functions.
 This is usually easy when `SELECT postgis_extensions_upgrade()` is able to
 package those raster functions, as then you just drop the extension, but
 you stumbled upon a bug which prevents packaging of those functions (now
 filed as #5550), and is a bug that's most likely only encountered when
 using a sandboxed system, because we do have regression testing in place
 and all bots are happy with the repackaging of raster (see #5212 for a
 ticket to request improving the CI coverage to add this case).

 The above said, I'm not sure there's much more to do in this ticket. The
 main problem was that the upgrade script from 3.2.3 to 3.3.2 failed to
 drop the st_orderingequals, but we didn't yet confirm it was due to
 sandboxing. I'm not sure your invocation of {{{
 SELECT _postgis_drop_function_if_needed
         (
         'st_orderingequals_deprecated_by_postgis_300',
         'GeometryA geometry, GeometryB geometry'
         );
 }}}

 Did something or not, maybe you can re-run after {{{ set
 client_min_messages to DEBUG; }}} to know more ? What we are interested in
 is WHY that function wasn't removed when you initially upgraded.
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5545#comment:11>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.