[postgis-tickets] [PostGIS] #5569: postgis_restore doesn't strip some old functions

[PostGIS]

#5569: postgis_restore doesn't strip some old functions
------------------------------------+-----------------------------
  Reporter:  kesar                  |      Owner:  strk
      Type:  defect                 |     Status:  new
  Priority:  low                    |  Milestone:  PostGIS 3.4.1
 Component:  build/upgrade/install  |    Version:  3.4.x
Resolution:                         |   Keywords:  postgis_restore
------------------------------------+-----------------------------
Changes (by strk):

 * cc: prasey (added)

Comment:

 The `pgis_abs_in` signature was deprecated in 2.5.0 according to
 postgis/postgis_legacy.c and there's a mention in it in
 doc/rfc/postgis_rfc_03_sheet.txt that I don't understand (rfc03 was
 commited by Paul in 2009: ideas Paul?)

 What's clearly missing is a DROP of that function in any of the upgrade
 scripts, which means whoever is upgrading from a version < 2.5.0 might
 have that function left in the database. The regress/core/regress.sql test
 should catch this case reporting `unexpected probin` but none of our bots
 are testing upgrades from 2.4.x: oldest upgrade is tested by woodie from
 2.5.9: https://woodie.osgeo.org/repos/30/pipeline/1305/14

 So, Paul or Regina: any idea why we'd ever want to keep those old
 functions rather than dropping them on upgrade (adding them to
 postgis_after_upgrade or something ?)

 The only reason for that I can think of is that our upgrade script is not
 able to change the "geometry" TYPE definition and thus will STILL use the
 old functions, but it would not seem a good reason to keep old function
 around to me (rather we should fix the upgrade)
-- 
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5569#comment:3>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.