[PostGIS] #5857: compile against PostgreSQL 18 failing gserialized_estimate.c:1508:17: error: too few arguments to function 'vacuum_delay_point'
PostGIS
trac at osgeo.org
Sun Mar 2 18:45:06 PST 2025
#5857: compile against PostgreSQL 18 failing gserialized_estimate.c:1508:17:
error: too few arguments to function 'vacuum_delay_point'
----------------------+---------------------------
Reporter: robe | Owner: robe
Type: defect | Status: new
Priority: blocker | Milestone: PostGIS 3.5.3
Component: postgis | Version: 3.4.x
Resolution: | Keywords:
----------------------+---------------------------
Description changed by robe:
Old description:
> I just tried building against PostgreSQL 18 master head
>
> and got this error:
>
> {{{
> geography_measurement_trees.o geography_measurement_trees.c
> gserialized_estimate.c: In function 'compute_gserialized_stats_mode':
> gserialized_estimate.c:1508:17: error: too few arguments to function
> 'vacuum_delay_point'
> 1508 | vacuum_delay_point();
> | ^~~~~~~~~~~~~~~~~~
> In file included from gserialized_estimate.c:97:
> C:/ming64/projects/POSTGR~1/rel/pg18w64/include/server/commands/vacuum.h:362:13:
> note: declared here
> 362 | extern void vacuum_delay_point(bool is_analyze);
> | ^~~~~~~~~~~~~~~~~~
> gserialized_estimate.c:1726:17: error: too few arguments to function
> 'vacuum_delay_point'
> 1726 | vacuum_delay_point();
> | ^~~~~~~~~~~~~~~~~~
> C:/ming64/projects/POSTGR~1/rel/pg18w64/include/server/commands/vacuum.h:362:13:
> note: declared here
> 362 | extern void vacuum_delay_point(bool is_analyze);
> | ^~~~~~~~~~~~~~~~~~
> make[1]: *** [<builtin>: gserialized_estimate.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make[1]: Leaving directory '/projects/postgis/postgis-git/postgis'
> make: *** [GNUmakefile:36: all] Error 1
>
> }}}
New description:
I just tried building against PostgreSQL 18 master head
and got this error:
{{{
geography_measurement_trees.o geography_measurement_trees.c
gserialized_estimate.c: In function 'compute_gserialized_stats_mode':
gserialized_estimate.c:1508:17: error: too few arguments to function
'vacuum_delay_point'
1508 | vacuum_delay_point();
| ^~~~~~~~~~~~~~~~~~
In file included from gserialized_estimate.c:97:
C:/ming64/projects/POSTGR~1/rel/pg18w64/include/server/commands/vacuum.h:362:13:
note: declared here
362 | extern void vacuum_delay_point(bool is_analyze);
| ^~~~~~~~~~~~~~~~~~
gserialized_estimate.c:1726:17: error: too few arguments to function
'vacuum_delay_point'
1726 | vacuum_delay_point();
| ^~~~~~~~~~~~~~~~~~
C:/ming64/projects/POSTGR~1/rel/pg18w64/include/server/commands/vacuum.h:362:13:
note: declared here
362 | extern void vacuum_delay_point(bool is_analyze);
| ^~~~~~~~~~~~~~~~~~
make[1]: *** [<builtin>: gserialized_estimate.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/projects/postgis/postgis-git/postgis'
make: *** [GNUmakefile:36: all] Error 1
}}}
Failure is caused by this PostgreSQL commit 3 weeks ago. Unfortunately
debbie's git was having issue so the pg18 build-env builds were failing so
didn't catch this:
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=e5b0b0c
{{{
Add is_analyze parameter to vacuum_delay_point().
This function is used in both vacuum and analyze code paths, and a
follow-up commit will require distinguishing between the two. This
commit forces callers to specify whether they are in a vacuum or
analyze path, but it does not use that information for anything
yet.
Discussion: https://postgr.es/m/ZmaXmWDL829fzAVX%40ip-10-97-1-34.eu-
west-3.compute.internal
}}}
--
--
Ticket URL: <https://trac.osgeo.org/postgis/ticket/5857#comment:2>
PostGIS <http://trac.osgeo.org/postgis/>
The PostGIS Trac is used for bug, enhancement & task tracking, a user and developer wiki, and a view into the subversion code repository of PostGIS project.
More information about the postgis-tickets
mailing list