[PROJ] spilhaus regresssion test failures

[Charles Karney]

Since I'm the author of this PR, I'm happy to weigh in once the
failure gets narrowed down.

  --Charles

On Sun, May 4, 2025 at 12:58 PM Javier Jimenez Shaw via PROJ
<proj at lists.osgeo.org> wrote:
>
>
>
> On Sun, 4 May 2025 at 16:32, Greg Troxel <gdt at lexort.com> wrote:
>>
>> Javier Jimenez Shaw <j1 at jimenezshaw.com> writes:
>>
>> > The failures in the roundtrip suggest that the problem is in the inverse
>> > function of the spilhaus projection.
>> > Part of the code used there was refactored end of March in master, and
>> > maybe the new code/formulation behaves better in NetBSD.
>> >
>> > Could you test master in your environment?
>>
>> Thanks for the hint.  I ran a build/check from git master, and got a
>> clean pass.
>>
>> I guess we don't know if the problem was in the previous code, or it was
>> ok and triggers a NetBSD bug, but I would guess since you changed things
>> on master you think it's better and there's no need to dig into it.
>>
>
> The PR was https://github.com/OSGeo/PROJ/pull/4446
>
> Maybe the function that impacts the tests is "pj_conformal_lat_inverse". You can try with the new implementation.
> The changes should be small. (See that the signature of the function is a bit different). It is used only in one place.
>
>>
>>
>>   17/68 Testing: spilhaus
>>   17/68 Test: spilhaus
>>   Command: "/n0/gdt/SOFTWARE/GEO/PROJ/proj/BUILD/bin/gie" "/n0/gdt/SOFTWARE/GEO/PROJ/proj/test/gie/spilhaus.gie"
>>   Directory: /n0/gdt/SOFTWARE/GEO/PROJ/proj/test
>>   "spilhaus" start time: May 04 10:17 EDT
>>   Output:
>>   ----------------------------------------------------------
>>   -------------------------------------------------------------------------------
>>   Reading file '/n0/gdt/SOFTWARE/GEO/PROJ/proj/test/gie/spilhaus.gie'
>>   -------------------------------------------------------------------------------
>>   total: 133 tests succeeded,  0 tests skipped,  0 tests failed.
>>   -------------------------------------------------------------------------------
>>   <end of output>
>>   Test time =   0.04 sec
>>   ----------------------------------------------------------
>>   Test Passed.
>>   "spilhaus" end time: May 04 10:17 EDT
>>   "spilhaus" time elapsed: 00:00:00
>>   17/68 Testing: spilhaus
>>   17/68 Test: spilhaus
>>   Command: "/n0/gdt/SOFTWARE/GEO/PROJ/proj/BUILD/bin/gie" "/n0/gdt/SOFTWARE/GEO/PROJ/proj/test/gie/spilhaus.gie"
>>   Directory: /n0/gdt/SOFTWARE/GEO/PROJ/proj/test
>>   "spilhaus" start time: May 04 10:17 EDT
>>   Output:
>>   ----------------------------------------------------------
>>   -------------------------------------------------------------------------------
>>   Reading file '/n0/gdt/SOFTWARE/GEO/PROJ/proj/test/gie/spilhaus.gie'
>>   -------------------------------------------------------------------------------
>>   total: 133 tests succeeded,  0 tests skipped,  0 tests failed.
>>   -------------------------------------------------------------------------------
>>   <end of output>
>>   Test time =   0.04 sec
>>   ----------------------------------------------------------
>>   Test Passed.
>>   "spilhaus" end time: May 04 10:17 EDT
>>   "spilhaus" time elapsed: 00:00:00
>>
>>
>> You may be amused by this test failure:
>>
>>   Test 95 failed
>>   /n0/gdt/SOFTWARE/GEO/PROJ/proj/BUILD/bin/projinfo completion projinfo --pivot-crs
>>   Different stdout+stderr returned (+) than expected (-):
>>   - always if_no_direct_transformation never EPSG: ESRI: IAU_2015: IGNF: NKG: NRCAN: OGC: PROJ:
>>   + always if_no_direct_transformation never EPSG: ESRI: IAU_2015: IGNF: NKG: NRCAN: NSRS: OGC: PROJ:
>>   ?                                                                                  ++++++
>>
>> which is obviously not an actual bug -- I had your NSRS db hooked in via
>> PROJ_AUX_DB.
>
> The auxiliary database usage is not widely tested. That command is printing all the authorities, and you have a new one ;)
> _______________________________________________
> PROJ mailing list
> PROJ at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/proj



-- 
Charles Karney <karney at alum.mit.edu>
702 Prospect Ave
Princeton, NJ 08540