[PyWPS-dev] Database Output Storage pull request - Codacy/PR Quality Review

[Carsten Ehbrecht]

Hi Jan,

Late and short response.

2) using assert in tests seems to be fine … but not for regular code.

1) I can’t say about subprocess calls …I just followed the notes in the python docu:
https://docs.python.org/3.5/library/subprocess.html <https://docs.python.org/3.5/library/subprocess.html>

… like not using "shell=True”

Cheers,
Carsten


> On 22 Jan 2019, at 5:26 pm, Jan Pišl <janjanpisl at gmail.com> wrote:
> 
> Hi all!
> 
> I am finalizing my pull request [1] that implements database storage for output data from PyWPS processes. The pull request does not pass the Codacy/PR Quality Review check. I have fixed everything I could but there are some issues [2] I am not sure how to tackle, so I want ask you all what you think:
> 
> 1)  Using run and call modules that might have some security implications
> 
> Can I use those modules or do I need to replace them? 
> 
> 2) Using "assert" in tests
> 
> Is that ok or should I change that? If so, change to what?
> 
> 
> Thank you for any help or advice!
> 
> Kind regards,
> 
> Jan Pisl
> 
> [1] https://github.com/geopython/pywps/pulls <https://github.com/geopython/pywps/pulls>
> [2] https://app.codacy.com/app/cehbrecht/pywps/pullRequest?prid=2042872 <https://app.codacy.com/app/cehbrecht/pywps/pullRequest?prid=2042872>_______________________________________________
> pywps-dev mailing list
> pywps-dev at lists.osgeo.org
> https://lists.osgeo.org/mailman/listinfo/pywps-dev

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/pywps-dev/attachments/20190311/a4922501/attachment.html>