[Qgis-developer] Development needed: Georeferencer plugin

[Tim Sutton]

Hi

Agreed Ill roll it back.

Regards

Tim
Em 22/05/2007, às 17:41, Martin Dobias escreveu:

> Hi Tim,
>
> I'm not much in favour of applying that patch. As Oleg writes, it's
> just a quick hack. While it makes possible what has been asked for,
> it's not a definitive solution - definitely should be done with a map
> tool.
>
> What's wrong with the patch:
> - it pollutes canvas API with an additional signal (not speaking about
> the need to add class changes to python bindings)
> - it generically uses right click - might interfere with other map  
> tools
> - no user and developer documentation (who besides few people on
> qgis-dev list will know about this 'feature' ?)
>
> These are my thoughts - hacks shouldn't go to svn, at least not to the
> public API. And since canvas is part of public API and we should twice
> when we change it.
>
> Regards
> Martin
>
>
> On 5/22/07, Tim Sutton <tim at linfiniti.com> wrote:
>> Hi
>>
>> I patched this into HEAD. 0.8 branch is in feature freeze - I can add
>> it after 0.8.1 release.
>>
>> Many thanks
>>
>> Regards
>>
>> Tim
>>
>> Em 22/05/2007, às 08:20, Oleg Gusev escreveu:
>>
>> > Am Dienstag, 22. Mai 2007 12:19 schrieben Sie:
>> >> Hi,
>> >>
>> >> is that based on latest SVN or based on qgis 0.8 release?
>> >>
>> > Here is the diff to the latest SVN, and i have checked that it  
>> works.
>> >
>> >  Oleg.
>> > <georef1.diff>
>> > _______________________________________________
>> > Qgis-developer mailing list
>> > Qgis-developer at lists.qgis.org
>> > http://lists.qgis.org/cgi-bin/mailman/listinfo/qgis-developer
>>
>> _______________________________________________
>> Qgis-developer mailing list
>> Qgis-developer at lists.qgis.org
>> http://lists.qgis.org/cgi-bin/mailman/listinfo/qgis-developer
>>