AW: [Qgis-developer] RFC vector data providers handling

[Hugentobler Marco]

Hi Jürgen,

>editConnection() would be in the provider plugin, but not necessarily in
>the provider class.
>
>The app/ classes wouldn't need to know about individual providers, just
>about the provider registry.  That way we could also add new providers
>including the necessary gui to create them without even touching app/ at
>all.

This sounds good. If the dialog is not included into the provider itself then I think it would be ok. And yes, valid point that app does not need to be touched to add a new provider.

>That patch isn't what I proposed.  It's just what made me think.

Ok, I see. 

Regards,
Marco

-----Ursprüngliche Nachricht-----
Von: Jürgen E. Fischer [mailto:jef at norbit.de]
Gesendet: Mi 30.04.2008 10:09
An: Hugentobler  Marco
Cc: qgis-developer at lists.osgeo.org; godofredo contreras
Betreff: Re: [Qgis-developer] RFC vector data providers handling
 
Hi Marco,

On Wed, 30. Apr 2008 at 09:02:20 +0200, Marco Hugentobler wrote:
> One thing that in my opinion is important to consider is to keep GUI and 
> references to dialogs out of the provider classes.
> A possibility might be to have a specific dialog class for each provider that 
> is able to create a provider from GUI input. Like this the dialog knows about 
> the provider, but not the other way round.

> Am Dienstag 22 April 2008 19:37:09 schrieb Jürgen E. Fischer:
> > QGISEXTERN bool editConnection(QString connection);
> > // would be tied to the add/edit button and add/edit a selected
> > // connection in the combobox and open a provider specific dialog box.
> > // That gui could optionally include and "Add Layer..." button to create
> > // a new layer (ie. QgsGeomTypeDialog for OGR, but not tied to just
> > // shapes).

editConnection() would be in the provider plugin, but not necessarily in
the provider class.

The app/ classes wouldn't need to know about individual providers, just
about the provider registry.  That way we could also add new providers
including the necessary gui to create them without even touching app/ at
all.

> I'm trying to have a closer look at Juergens patch in the next days and 
> possibly will then have a more complete understanding of the proposed 
> changes.

That patch isn't what I proposed.  It's just what made me think.
 

Jürgen

-- 
Jürgen E. Fischer         norBIT GmbH               Tel. +49-4931-918175-0
Dipl.-Inf. (FH)           Rheinstraße 13            Fax. +49-4931-918175-50
Software Engineer         D-26506 Norden               http://www.norbit.de

-- 
norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH
Rheinstrasse 13, 26506 Norden
GF: Jelto Buurman, HR: Amtsgericht Emden, HRB 5502