AW: cleanups (was Re: [Qgis-developer] Next release name - 'Metis')

[Hugentobler Marco]

Hi,

+1 also for me.

Regards,
Marco


-----Ursprüngliche Nachricht-----
Von: qgis-developer-bounces at lists.osgeo.org im Auftrag von Tim Sutton
Gesendet: Mi 14.05.2008 15:25
An: Jürgen E. Fischer
Cc: QGIS Developer Mailing List
Betreff: Re: cleanups (was Re: [Qgis-developer] Next release name - 'Metis')
 
Hi

+1 for these changes from me. I think if you are going to be doing a
big batch change like this it would be good to do the following way:

1) Tag before-big-change
2) Call for all developers to put in any outstanding commits, patches
etc (many may get broken by such a batch change)
3) Apply debug and code formatting changes
4) Tag after-big-change
5) Announce devs can continue on with their work.

It may be good to fish out that svn commit hook we discussed once and
apply it after you changes such that any new code going in
automatically gets formatted on the way into SVN.

Regards

Tim

2008/5/13 Jürgen E. Fischer <jef at norbit.de>:
> Hi,
>
>  On Tue, 13. May 2008 at 08:24:22 +0200, Hugentobler  Marco wrote:
>  > It would also be good to make code cleaning sometime, e.g. cleaning
>  > out old comments and legacy code. I'm however not sure if developers
>  > have enough time to do that for the next release. I can imagine the
>  > 'code cleaning festival' one release after the 'performance boosting
>  > festival' (so probably before 1.0).
>
>  I also wanted to address some things:
>
>  1. move the remaining debug output using iostream to QgsDebugMsg:
>
>   I created a perl script [1], that needs a little patch[2] to fix some
>   cases the script doesn't handle. After running the script you end up
>   with patch [3].
>
>  2. fix whitespace use (lineendings and identation)
>
>   In the repository there are currently not all files using the same
>   lineending causes problems when diffs are transfered.
>
>   I think Tim already prepared an input file for astyle[4] that match
>   our coding standards.  Which could use to get a homogenous look.
>
>
>  At least for me this would be really nice.  Most of the time I end up
>  reformatting code or inventing dumb scripts, instead of doing real work
>  :)
>
>
>  On Tue, 13. May 2008 at 16:44:49 +0200, Marco Hugentobler wrote:
>  > If there are no further issues or objections, I plan to merge the
>  > rendercontext-branch back to trunk on Thursday.
>
>  Are there more branches about to be committed?  Implementation of the
>  points above would make it quite hard to merge them...
>
>
>  Jürgen
>
>  [1] http://buten.norbit.de/~jef/qgsloggermig.pl
>  [2] http://buten.norbit.de/~jef/qgslogger-before.diff
>  [3] http://buten.norbit.de/~jef/qgslogger-after.diff
>  [4] http://astyle.sourceforge.net/
>
>  --
>  Jürgen E. Fischer         norBIT GmbH               Tel. +49-4931-918175-0
>  Dipl.-Inf. (FH)           Rheinstraße 13            Fax. +49-4931-918175-50
>  Software Engineer         D-26506 Norden               http://www.norbit.de
>
>  --
>  norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH
>  Rheinstrasse 13, 26506 Norden
>  GF: Jelto Buurman, HR: Amtsgericht Emden, HRB 5502
>
>



-- 
Tim Sutton
QGIS Project Steering Committee Member - Release  Manager
Visit http://qgis.org for a great open source GIS
openModeller Desktop Developer
Visit http://openModeller.sf.net for a great open source ecological
niche modelling tool
Home Page: http://tim.linfiniti.com
Skype: timlinux
Irc: timlinux on #qgis at freenode.net
_______________________________________________
Qgis-developer mailing list
Qgis-developer at lists.osgeo.org
http://lists.osgeo.org/mailman/listinfo/qgis-developer