[Qgis-developer] [Plugin] Added, deleted or changed features in a layer

Tim Sutton tim at linfiniti.com
Tue Jan 13 15:29:00 EST 2009


Hi

(Sorry for the delay)

On Sun, 2009-01-11 at 17:39 +0100, Olivier Tournaire wrote:
> OK
> 
> 2009/1/10 Tim Sutton <tim at linfiniti.com>
>         Hi
>         8<-------snip--------------
>         
>         >
>         > OK, I will attach the patch to ticket #1482 in a few days.
>         > Does my proposition in the ticket respect the coding
>         standards ?
>         
>         
>         We dont use 'get' get prefix for accessors, so they should be
>         called:
>         
>         const QgsFeatureIds?& deletedFeaturesIds() const
>         const QgsFeatureList?& addedFeatures() const
>         const QgsGeometryMap?& changedGeometries() const
> 
> Can I inline the methods or not ?

Its ok to inline where it makes sense to do so...


>  
>         
>         
>         Also dont forget the new methods should be added to the
>         corresponding
>         sip file so that they appear in python bindings!
> 
> OK. Is there only one file to change
> python/core/sipcoreQgsVectorLayer.cpp ?

Yes just that file.


Regards



-- 
Tim Sutton - QGIS Project Steering Committee Member (Release  Manager)
==============================================
Visit http://linfiniti.com to find out about:
 * QGIS programming services
 * Mapserver and PostGIS based hosting plans
 * FOSS Consulting & Support Services
Skype: timlinux Irc: timlinux on #qgis at freenode.net
==============================================
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
Url : http://lists.osgeo.org/pipermail/qgis-developer/attachments/20090113/f0b0b532/attachment.bin


More information about the Qgis-developer mailing list