[Qgis-developer] Typo in QgsRasterLayer enum

[Marco Hugentobler]

Hi Peter

The probability that we are going to forget about it once v2.0 is out seems 
quite high to me. Wouldn't it be better to just rename it (even if we break 
strict interface compatibility?).
How do others feel about it?

Regards,
Marco

Am Montag, 9. August 2010, um 21.22:21 schrieb Peter Ersts:
> Howdy devs,
> 
> Last night  I was looking through the QgsRasterLayer code and noticed a
> typo in the DrawingStyle enum that made it in during the major renaming
> efforts  (r9564 & r9566) just before version 1.0 was released.
> 
> MultiBandSingleGandGray should be MultiBandsingleBandGray
> 
> Question is how do we go about fixing it and preserving compatibility?
> 
> I was thinking we would need to:
> 1) add the correctly spelled enum
> 2) use both enums where ever the incorrect one appears, example
> if( QgsRasterLayer::MultiBandSingleGandGray )
> becomes
> if( QgsRasterLayer::MultiBandSingleGandGray ||
> QgsRasterLayer::MultiBandsingleBandGray )
> 3) Wait until v2.0 to drop MultiBandSingleGandGray enum
> 
> -pete


-- 
Dr. Marco Hugentobler
Sourcepole -  Linux & Open Source Solutions
Webereistrasse 66, 8134 Adliswil, Switzerland
marco.hugentobler at sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee