[Qgis-developer] plugin bug and patch - RGB composition plugin broken in 1.7.4 and master

Etienne Tourigny etourigny.dev at gmail.com
Wed Mar 7 19:30:20 EST 2012


The RGB composition plugin does not work (throws error below when
operation is requested)

The plugin has not homepage nor project page and is listed on the old
plugin page
http://pyqgis.org/repo/contributed

How does one submit bugs for these plugins, and how does one get them updated?

Here is a small patch that fixes the problem
===
diff -r -U 1 rgb.old//Rgb.py rgb/Rgb.py
--- rgb.old//Rgb.py	2010-04-10 18:31:18.000000000 -0300
+++ rgb/Rgb.py	2012-03-07 21:19:39.000000000 -0300
@@ -40,2 +40,5 @@
         self.layermap=QgsMapLayerRegistry.instance().mapLayers()
+        self.pluginGui.comboBox_3.clear()
+        self.pluginGui.comboBox_4.clear()
+        self.pluginGui.comboBox_5.clear()
         for (name,layer) in self.layermap.iteritems():
@@ -48,3 +51,8 @@
     def makergb(self):
-        composite.rgb(str(self.pluginGui.comboBox_3.currentText()),str(self.pluginGui.comboBox_4.currentText()),str(self.pluginGui.comboBox_5.currentText()),str(self.pluginGui.lineEdit.text()))
+#        composite.rgb(str(self.pluginGui.comboBox_3.currentText()),str(self.pluginGui.comboBox_4.currentText()),str(self.pluginGui.comboBox_5.currentText()),str(self.pluginGui.lineEdit.text()))
+        items = self.layermap
+        source3 =
str(items[QString(str(self.pluginGui.comboBox_3.currentText()))].source())
+        source4 =
str(items[QString(str(self.pluginGui.comboBox_4.currentText()))].source())
+        source5 =
str(items[QString(str(self.pluginGui.comboBox_5.currentText()))].source())
+        composite.rgb(source3,source4,source5,str(self.pluginGui.lineEdit.text()))
         rgblayer=QgsRasterLayer(str(self.pluginGui.lineEdit.text()),"Add
RGB Composition")
===


Here is the error in 1.7.4 ( I get roughly the same in master)
===
An error has occured while executing Python code:

Traceback (most recent call last):
  File "/home/tourigny/.qgis/python/plugins/rgb/Rgb.py", line 49, in makergb
    composite.rgb(str(self.pluginGui.comboBox_3.currentText()),str(self.pluginGui.comboBox_4.currentText()),str(self.pluginGui.comboBox_5.currentText()),str(self.pluginGui.lineEdit.text()))
  File "/home/tourigny/.qgis/python/plugins/rgb/composite.py", line 18, in rgb
    x=r.RasterXSize
AttributeError: 'NoneType' object has no attribute 'RasterXSize'

Python version:
2.7.2+ (default, Oct  4 2011, 20:41:12)
[GCC 4.6.1]


QGIS version:
1.7.4-Wroclaw Wroclaw, exported

Python path: ['/usr/share/qgis/python', '/home/tourigny/.qgis/python',
'/home/tourigny/.qgis/python/plugins',
'/usr/share/qgis/python/plugins',
'/home/soft/lib/python2.7/site-packages/cfchecker-2.0.3-py2.7.egg',
'/home/soft/lib/python2.7/site-packages/GDAL-1.8.1-py2.7-linux-x86_64.egg',
'/home/soft/lib/python2.7/site-packages', '/usr/lib/python2.7',
'/usr/lib/python2.7/plat-linux2', '/usr/lib/python2.7/lib-tk',
'/usr/lib/python2.7/lib-old', '/usr/lib/python2.7/lib-dynload',
'/usr/local/lib/python2.7/dist-packages',
'/usr/lib/python2.7/dist-packages',
'/usr/lib/python2.7/dist-packages/PIL',
'/usr/lib/python2.7/dist-packages/gst-0.10',
'/usr/lib/python2.7/dist-packages/gtk-2.0',
'/usr/lib/pymodules/python2.7',
'/usr/lib/python2.7/dist-packages/wx-2.8-gtk2-unicode',
'/usr/share/qgis/python',
'/usr/share/qgis/python/plugins/fTools/tools']
===


Cheers,
Etienne


More information about the Qgis-developer mailing list