[Qgis-developer] September 1 branch for release

[Larry Shaffer]

Hi Michael,

On Fri, Aug 30, 2013 at 8:28 AM, kimaidou <kimaidou at gmail.com> wrote:

> Hi all
>
> I have another person who told me "I have weird label sizes with QGIS
> Server".
> Larry, sorry to ask again, but do you think you will be able to solve
> http://hub.qgis.org/issues/8068 before the 1st ?
>
>
Ugh! I was hoping to have that done by now, but several things conspired
against me this week. This is a very significant issue and very laborious
to test across platforms. Also, it appears to even be different between
host web servers (no idea how that's happening)!

I very much apologize for the delay in a fix. Here is why it is a
time-consuming fix:

* The difference in resolutions of output paint devices affects EVERYTHING
in the new labeling features (e.g. shadows, backgrounds). This is because
of the means in which I coded the 'storing' of the label component's
painting to canvas, so that I can use that info to later create the drop
shadows, etc. When I fix one part of the code, I have to *visually* test
many variations that might be affected (e.g. server, PDF and SVG exports).
This is because there were no unit tests for the labeling code at all (I
take responsibility for some of that).

* So... I made the uncomfortable decision to create a comprehensive
labeling test suite right now. The idea being, I add a single unit test and
it is inherited by classes that test its output to canvas, composer (PDF,
SVG), and server (and composer and server outputs against canvas), and have
any errors pop up test comparisons in a web browser. This way I can
immediately open a virtual machine for other platforms, build the tests and
*see* all of the errors in browser tabs. (about 100 times faster)

* I am not done with the test classes (need to finish composer's, at a
minimum). Hope to have it done today.

* I also found it very time-consuming to configure/maintain test web
servers on all of the test machines. So... I made not only an Python
interface to help test server output, but also recently coded an embedded
fcgi spawner and Python interface to it (fcgi-spawn and flup client). This
means a completely separate fcgi process can be spawned and queried for
unit tests (as a background process), regardless of the the machine's
installed web servers/configurations.

The embedded fcgi spawner also means that for 2.1 we can have a menu item
'Show project in test server...' which can pop up a QWebView connected to
the embedded server :^), assuming the data sources can be concurrently
accessed.

So... why did I take the long way around to try and fix this? Because the
variations are so large that without tests I had no reasonable way of
determining if my 'fix' didn't break something else.


**Essentially, at this point, I might be able to fix it by Sunday, but
having 1 more week, I know I can.**


Thanks for any update, we can help by trying your branch if needed
>

Yes, that would be greatly appreciated! I would need to know which OS's you
can test under (the more the better) and which host servers (Apache, Nginx,
etc.).

If I can get my work cleaned up today, I will let you know. I need to
finish the minimum test suite so that you can also run the tests to help
verify the fix is good to go. I will not bother to finish coding the local
embedded server's install and unattended spawning, since you can manually
spawn/kill it for the duration of the tests.

Regards,

Larry




> Cheers
> Michael
>
>
> 2013/8/28 Paolo Cavallini <cavallini at faunalia.it>
>
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Il 28/08/2013 01:51, Larry Shaffer ha scritto:
>>
>> >         Assuming you intend to go ahead with 1 Sept tagging, will we
>> still be able to
>> >         commit to the master branch in between 25 Aug and 1 Sept?
>>
>> Hi Larry,
>> will this include a fix to the blocker?
>> All the best, and thanks.
>>
>> - --
>> Paolo Cavallini - Faunalia
>> www.faunalia.eu
>> Full contact details at www.faunalia.eu/pc
>> Nuovi corsi QGIS e PostGIS: http://www.faunalia.it/calendario
>> -----BEGIN PGP SIGNATURE-----
>> Version: GnuPG v1.4.14 (GNU/Linux)
>> Comment: Using GnuPG with Icedove - http://www.enigmail.net/
>>
>> iEYEARECAAYFAlIdmH8ACgkQ/NedwLUzIr6dkACePVcB2o4O71T8uXRRbPe/XgKl
>> /5sAmgNh28zn8Bwy0OeSf0UXGt3ynqu2
>> =+ZZU
>> -----END PGP SIGNATURE-----
>> _______________________________________________
>> Qgis-developer mailing list
>> Qgis-developer at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>>
>
>
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20130830/efa2cd87/attachment.html>