[Qgis-developer] Fwd: Re: WG: "Rectangles ovals digitizing" plugin is broken in QGIS 1.9

[vinayan]

Dear All,

Today I got a mail from one of our users mentioning that the plugin 
"Rectangles ovals digitizing" is broken. He first contacted the plugin 
author and it seems he is not currently supporting it. I made the 
changes so that the plugin works now. How can we can update the same fix 
in the contributed plugins repository? Is it hosted on github where a 
pull request can be issued? I am sure quite a few people would be using it.

Anyway, the fix is quite simple. Just a line in the canvasmove event for 
all methods(except rotategeometry) in rectovaldigittools.py

Like this..

#[self.rb.addPoint( point ) for point in polygon]
  self.rb.setToGeometry(QgsGeometry.fromPolygon([polygon]), None)


Thanks
Vinayan


-------- Original Message --------
Subject: 	Re: WG: "Rectangles ovals digitizing" plugin is broken in QGIS 
1.9
Date: 	Tue, 22 Jan 2013 08:24:00 +0530
From: 	vinayan <vinayan123 at gmail.com>
To: 	Gerhard Spieles <gerhard at spieles.de>



On Tuesday 22 January 2013 02:27 AM, Gerhard Spieles wrote:
> Dear Vinayan Parameswaran,
>
> i have received a message from QGIS bug tracker, that you programmed the rotation feature for all sort objects Lines and polygons) in QGIS core (Feature #1787).
>
> Now I contact you, because of a similar problem.
> There exist a "Rectangles ovals digitizing" plugin, programmed by Pavol Kapusta  ver. 0.1.3 (http://pyqgis.org/repo/contributed). ZIP Archive is attached.
> This excellent programmed plugin can create all regular polygons from triangle,  rectangle, square pentagon hexagon ....   until circle and is able to rotate polygons.
> It functions until QGIS 1.8.0.
> In QGIS master (ver 1.9.0 Alpha), the produced geometries seems not to be closed and when you try to save a produced object, gdal reports, that a line feature can`t saved in a polygon layer.
> Unfortunately Pavol  can`t continue the plugin.
>
> I would ask, wether it is possible, that you  fix the plugin or to take it  into QGIS core in the advanced editing toolbar.
>
> Awaiting hopefully a positive response
>
> Best regards
> Gerhard Spieles
>
>
> -----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
> -----Ursprüngliche Nachricht-----
> Von: Pavol Kapusta [mailto:pavol.kapusta at gmail.com]
> Gesendet: Donnerstag, 17. Januar 2013 18:45
> An: Gerhard Spieles
> Betreff: Re: "Rectangles ovals digitizing" plugin is broken in QGIS 1.9
>
> Dear Gerhard Spieles,
>
> I am totally out of GIS business (even don't have QGIS installed on my system around a year), so I am sorry, it is highly unlikely I will contribute to the project.
>
> Best regards
> Pavol
>
> Dňa 16.01.2013 23:06, Gerhard Spieles wrote / napísal(a):
>> Dear Pavol Kapusta,
>>
>> your plugin for QGIS is a great digitizing tool for generate regular
>> polygons in QGIS.
>>
>> Unfortunately, the plugin reports errors in QGIS 1.9.0 Alpha
>> (QGIS-master). It seems, that the produced objects are not closed.
>>
>> Is it possible to make the plugin functional in QGIS 1.9
>>
>> Thank you very much and best regards
>>
>> Gerhard Spieles
>>
Dear Gerhard,

It is a nice plugin indeed. I checked it and it had the same errors you
mentioned.I have fixed its issues and attached it. Please check.
I will send a mail to the dev list to know how we can update the same
fix in the repository.

Thanks
Vinayan




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20130122/18a4bbf0/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: rectovalDigit.zip
Type: application/zip
Size: 42302 bytes
Desc: not available
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20130122/18a4bbf0/attachment-0001.zip>