[Qgis-developer] QGIS Server - GetPrint request does not respect text boxes size and position if dynamic content passed

[Marco Hugentobler]

 >So for me, simply removing the adjustSizeToText call would be enough. 
Or we have to make sure this method does the job correctly, which may be 
a bit hard to implement : we need to avoid to have >collision with other 
composition items, etc.

The problem is if the client provided text does not fit into the 
predefined label box. It would be good to combine dynamic resize 
capabilities with line breaks somehow.
I'm open for suggestions.

Marco


On 28.05.2013 11:53, kimaidou wrote:
> Hi
>
> I just made a small test and commented the line
> currentLabel->adjustSizeToText();
> Then recompile QGIS master and tested it with a classical text box 
> (not html rendered) with a long text.
>
> I personnaly prefer the behaviour when this method is not called : the 
> text box keep the size set by the user in QGIS. And the text wraps 
> when it reaches the right side of the Box. I even tried with "HTML 
> rendered" on (and my fake X Server running), and it worked well too.
>
> At the contrary, when adjustSizeToText is used, the box is transformed 
> in a one line box, which goes to the right of the entire composition 
> (out of it) : text does not wrap.
>
> So for me, simply removing the adjustSizeToText call would be enough. 
> Or we have to make sure this method does the job correctly, which may 
> be a bit hard to implement : we need to avoid to have collision with 
> other composition items, etc.
>
> Regards
> Michael
>
>
>
> 2013/5/28 René-Luc D'Hont <rldhont at gmail.com <mailto:rldhont at gmail.com>>
>
>     Hi Marco
>
>
>         I guess yes. 'adjustSizeToText()' works for text, not html.
>         Html support for composer label was added recently to the
>         composer label class. Please adapt the relevant lines to work
>         with html labels too. 
>
>
>     I'll adapt it
>
>
>         >Question for Marco, Why removed label, if the request doesn't
>         define a value ? Why not used the default value ?
>
>         The idea was that the web client has the possibility to remove
>         an advertised text label completely if it is not used. E.g. if
>         a composition defines a text item with id 'author', the web
>         client can simply ignore it if it does not want to have
>         author's name printed. Note that the labels without ids are
>         not removed as they are considered to be fix, so not subject
>         to client text replacement (original meaning of label id was
>         that this text item is subject to text replacement by web
>         client. Later, the id has been generalized as an id for every
>         item type).
>
>         Another possibility would be to remove the item only if the
>         client gives an empty text and use the default text otherwise.
>         What do you think?
>
>
>
>     I prefer to remove the label only if the user gives an empty text.
>     Can I do it ?
>
>
>     Regards,
>     René-Luc
>
>
>     On 27.05.2013 22 <tel:27.05.2013%2022>:23, rldhont wrote:
>
>             Hi Marco and other devs,
>
>             In src/mapserver/qgsconfigparser.cpp:530 we can read :
>
>               //replace label text
>               foreach ( QgsComposerLabel *currentLabel, composerLabels )
>               {
>                 QString title = parameterMap.value(
>             currentLabel->id().toUpper() );
>
>                 if ( title.isEmpty() )
>                 {
>                   //remove exported labels not referenced in the request
>                   if ( !currentLabel->id().isEmpty() )
>                   {
>                     c->removeItem( currentLabel );
>                     delete currentLabel;
>                   }
>                   continue;
>                 }
>
>                 currentLabel->setText( title );
>                 currentLabel->adjustSizeToText();
>               }
>
>             This code is used to draw composer label with value
>             defined by the QGIS WMS Server Request GetPrint.
>
>             The bug defined in the issues #7894
>             http://hub.qgis.org/issues/7894 is probably du to the
>             method adjustSizeToText()
>             Someone can confim it ?
>
>             Question for Marco, Why removed label, if the request
>             doesn't define a value ? Why not used the default value ?
>
>             Regards,
>             René-Luc D'Hont
>             3Liz
>             _______________________________________________
>             Qgis-developer mailing list
>             Qgis-developer at lists.osgeo.org
>             <mailto:Qgis-developer at lists.osgeo.org>
>             http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>
>         -- 
>         Dr. Marco Hugentobler
>         Sourcepole -  Linux & Open Source Solutions
>         Weberstrasse 5, CH-8004 Zürich, Switzerland
>         marco.hugentobler at sourcepole.ch
>         <mailto:marco.hugentobler at sourcepole.ch> http://www.sourcepole.ch
>         Technical Advisor QGIS Project Steering Committee
>
>         _______________________________________________
>         Qgis-developer mailing list
>         Qgis-developer at lists.osgeo.org
>         <mailto:Qgis-developer at lists.osgeo.org>
>         http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>
>
>     _______________________________________________
>     Qgis-developer mailing list
>     Qgis-developer at lists.osgeo.org <mailto:Qgis-developer at lists.osgeo.org>
>     http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
>


-- 
Dr. Marco Hugentobler
Sourcepole -  Linux & Open Source Solutions
Weberstrasse 5, CH-8004 Zürich, Switzerland
marco.hugentobler at sourcepole.ch http://www.sourcepole.ch
Technical Advisor QGIS Project Steering Committee

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.osgeo.org/pipermail/qgis-developer/attachments/20130528/bdf693a0/attachment.html>