[Qgis-developer] PR1007 bump minimum to 4.7: objections?

[Nyall Dawson]

Ok - to add some context to this discussion -- I originally requested
that we bump the dependency to 4.6 to get access to
QGraphicsItem::rotation() and QGraphicsItem::setRotation(). I need
these to fix composer item rotation. It's a bit of a code cleanup, but
mostly a feature win in that using those methods I can add rotation to
all types of composer items. It's 98% of the way there in these
commits:
https://github.com/nyalldawson/QGIS/commit/bd92774ea7ea5ed50a4fad9c83f45540125d61e0
https://github.com/nyalldawson/QGIS/commit/f05dceb4bd63ca786aa36c0a60a8302567854889

Pull request 1007 is basically a prerequisite to finishing this work.
If there's no chance of getting the minimum to 4.6 then I'll have to
abandon this branch. That's why I'm hoping to get 1007 pulled before
spending too much more time on a feature which currently is impossible
to merge to master.

Early in this thread there was overwhelming support for setting the
minimum to 4.8 - that's why request 1006 was opened. 1006 can probably
be closed now since 4.8 looks unlikely.

Nyall


On 27 November 2013 21:43, Sandro Santilli <strk at keybit.net> wrote:
> May I ask why this discussion is happening here rather than
> on the pull request page ? I'd feel pretty lonely if I was
> the contributor of it... :(
>
> --strk;
>
> On Wed, Nov 27, 2013 at 11:26:05AM +0100, Jürgen E. Fischer wrote:
>> Hi Richard,
>>
>> On Wed, 27. Nov 2013 at 10:25:36 +0100, Richard Duivenvoorde wrote:
>> > > I don't see a point in this.  The pull request will just break the lucid
>> > > builds without adding anything new (or cleaning out any old code that
>> > > requires Qt <4.7).
>>
>> > Ok. Clear. Then we should close the two pull requests with the message: we
>> > want to provide lucid builds untill .... so before that time we will not
>> > upgrade Qt...
>>
>> Apparently not so clear.  Lucid is not the point.  It that it's just breaking
>> something w/o achieving anything else.  And that's essentially the only thing
>> it does.
>>
>> QGIS currently works with earlier versions.  That (tiny) change could be part
>> of a larger PR that removes all the old ifdefed code, that will become useless,
>> once QGIS refuses to be compiled on Qt <4.7 anyway.  Or when something else is
>> added that requires Qt 4.7 (and which needs some effort to to maintain for Qt
>> <4.7).
>>
>>
>> Jürgen
>>
>> --
>> Jürgen E. Fischer         norBIT GmbH               Tel. +49-4931-918175-31
>> Dipl.-Inf. (FH)           Rheinstraße 13            Fax. +49-4931-918175-50
>> Software Engineer         D-26506 Norden               http://www.norbit.de
>> QGIS PSC member (RM)                                   IRC: jef on FreeNode
>>
>> --
>> norBIT Gesellschaft fuer Unternehmensberatung und Informationssysteme mbH
>> Rheinstrasse 13, 26506 Norden
>> GF: Jelto Buurman, HR: Amtsgericht Emden, HRB 5502
>>
>> _______________________________________________
>> Qgis-developer mailing list
>> Qgis-developer at lists.osgeo.org
>> http://lists.osgeo.org/mailman/listinfo/qgis-developer
>
> --
>
>  ()  ASCII ribbon campaign        - against html e-mail
>  /\  http://www.asciiribbon.org   - against proprietary attachments
> _______________________________________________
> Qgis-developer mailing list
> Qgis-developer at lists.osgeo.org
> http://lists.osgeo.org/mailman/listinfo/qgis-developer